You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2015/09/29 23:24:04 UTC

[jira] [Commented] (THRIFT-3237) Fix TNamedPipeServer::createNamedPipe memory leak

    [ https://issues.apache.org/jira/browse/THRIFT-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935887#comment-14935887 ] 

James E. King, III commented on THRIFT-3237:
--------------------------------------------

This patch is flawed as the calls are inserted in such a way that they will corrupt the last error state from CreateNamedPipe in the error path.  I'm submitting a pull request that takes this into account to resolve this issue.

> Fix TNamedPipeServer::createNamedPipe memory leak
> -------------------------------------------------
>
>                 Key: THRIFT-3237
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3237
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.2
>         Environment: Windows
>            Reporter: Paweł Janicki
>            Priority: Critical
>         Attachments: 0001-THRIFT-3237.-cpp-Fix-TNamedPipeServer-createNamedPip.patch
>
>
> Some resources are not released



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)