You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/08/12 12:08:55 UTC

[PR] perf(table): avoid writer-factory lock on cache hits [iceberg-go]

fallintoplace opened a new pull request, #1782:
URL: https://github.com/apache/iceberg-go/pull/1782

   ## What changed
   
   - Return cached partition writers before taking the factory mutex.
   - Keep the locked recheck so concurrent cache misses still create one writer.
   - Add a concurrent creation regression test and a focused cache-hit benchmark.
   
   ## Benchmark
   
   Apple M1 Pro, Go 1.26.3, 8 benchmark workers:
   
   ```text
                                    before       after
   1 partition                     139.5 ns/op   2.6 ns/op
   8 partitions                    146.7 ns/op   3.1 ns/op
   128 partitions                  152.3 ns/op   3.8 ns/op
   ```
   
   All cases remain at 0 allocs/op.
   
   ## Testing
   
   - `go test ./table`
   - `go test -race ./table -run TestRollingDataWriter/TestConcurrentGetOrCreateCreatesOneWriter -count=20`
   - `go vet ./table`
   - `golangci-lint run --timeout=10m ./table/...`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] perf(table): avoid writer-factory lock on cache hits [iceberg-go]

Posted by "fallintoplace (via GitHub)" <gi...@apache.org>.
fallintoplace closed pull request #1782: perf(table): avoid writer-factory lock on cache hits
URL: https://github.com/apache/iceberg-go/pull/1782


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] perf(table): avoid writer-factory lock on cache hits [iceberg-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1782:
URL: https://github.com/apache/iceberg-go/pull/1782


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org