[jira] [Commented] (NIFI-4742) CaptureChangeMySQL memory/thread leak when enrichment connection cannot be made

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313798#comment-16313798 ] 

ASF GitHub Bot commented on NIFI-4742:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2379

    NIFI-4742: Clean up CaptureChangeMySQL connection resources on connect failure

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-4742

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2379
    
----
commit dee82b92a77e3d4d3f3f9c1bc3e6ea65c71f1256
Author: Matthew Burgess <ma...@...>
Date:   2018-01-05T20:08:20Z

    NIFI-4742: Clean up CaptureChangeMySQL connection resources on connect failure

----


> CaptureChangeMySQL memory/thread leak when enrichment connection cannot be made
> -------------------------------------------------------------------------------
>
>                 Key: NIFI-4742
>                 URL: https://issues.apache.org/jira/browse/NIFI-4742
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>
> CaptureChangeMySQL, in addition to making a connection to read the binary logs, will try to make a JDBC connection to the database in order to enrich the CDC events with information not in the binary logs themselves, such as column names/types. 
> However if an error occurs during set up of the JDBC connection (such as a missing driver, bad class name, etc.), the binary log connection (including keepalive thread) is not being cleaned up, and upon retry will create new threads, etc.
> If the JDBC connection cannot be set up successfully, all resources should be released and/or cleaned up for a fresh retry.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)