You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/18 15:11:02 UTC

[GitHub] [arrow] zeroshade commented on a change in pull request #12658: ARROW-15963: [Go][Parquet] simplify ReaderAtSeeker interface

zeroshade commented on a change in pull request #12658:
URL: https://github.com/apache/arrow/pull/12658#discussion_r830084595



##########
File path: go/parquet/file/row_group_reader.go
##########
@@ -31,7 +30,7 @@ const (
 
 // RowGroupReader is the primary interface for reading a single row group
 type RowGroupReader struct {
-	r             ipc.ReadAtSeeker
+	r             parquet.ReaderAtSeeker

Review comment:
       it didn't need to point at the `ipc.ReadAtSeeker` (which has the extra restriction of the `Read` method. it should be using `parquet.ReaderAtSeeker` which has fewer requirements.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org