[jira] [Commented] (CASSANDRA-2785) should export JAVA variable in the bin/cassandra and use that in the cassandra-env.sh when check for the java version

["Eric Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072222#comment-13072222 ] 

Eric Evans commented on CASSANDRA-2785:
---------------------------------------

The -n eval in bin/cassandra needs to be quoted or it'll read non-zero even when it's not.

{noformat}
--- a/bin/cassandra
+++ b/bin/cassandra
@@ -80,7 +80,7 @@ elif [ -r $CASSANDRA_INCLUDE ]; then
 fi
 
 # Use JAVA_HOME if set, otherwise look for java in PATH
-if [ -n $JAVA_HOME ]; then
+if [ -n "$JAVA_HOME" ]; then
     JAVA=$JAVA_HOME/bin/java
 else
     JAVA=java
{noformat}

Aside from that, +1

> should export JAVA variable in the bin/cassandra and use that in the cassandra-env.sh when check for the java version
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2785
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2785
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jackson Chung
>            Assignee: paul cannon
>         Attachments: 0001-use-JAVA-in-cassandra-env.sh.patch.txt
>
>
> I forgot which jira we add this java -version check in the cassandra-env.sh (for adding jamm to the javaagent), but we should probably use the variable JAVA set in bin/cassandra (will need export) and use $JAVA instead of "java" in the cassandra-env.sh
> In a situation where JAVA_HOME may have been properly set as the Sun's java but the PATH still have the OpenJDK's java in front, the check will fail to add the jamm.jar, even though the cassandra jvm is properly started via the Sun's java.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira