[GitHub] [iceberg] rdblue commented on a diff in pull request #6140: Python: Fix Evaluator tests

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6140:
URL: https://github.com/apache/iceberg/pull/6140#discussion_r1015778820


##########
python/tests/expressions/test_visitors.py:
##########
@@ -836,15 +843,23 @@ def _create_manifest_evaluator(bound_expr: BoundPredicate) -> _ManifestEvalVisit
     return evaluator
 
 
-def test_manifest_evaluator_less_than_no_overlap():
-    expr = BoundLessThan(
-        term=BoundReference(
-            field=NestedField(field_id=1, name="foo", field_type=StringType(), required=False),
-            accessor=Accessor(position=0, inner=None),
-        ),
-        literal=StringLiteral("c"),
-    )
+@pytest.fixture
+def string_schema() -> Schema:
+    return Schema(NestedField(field_id=1, name="foo", field_type=StringType(), required=False))

Review Comment:
   Nit: I'd prefer using better names that make the tests more readable, like like `str_col` because these are in a separate file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org