You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "robalar (via GitHub)" <gi...@apache.org> on 2026/02/13 15:42:59 UTC

[I] Expose several private functions to allow easier implemenation of `HttpService` and `HttpConnector` [arrow-rs-object-store]

robalar opened a new issue, #642:
URL: https://github.com/apache/arrow-rs-object-store/issues/642

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   Hi there 👋 I've been trying to implement the `HttpService` and `HttpConnector` traits to allow me to trace the HTTP calls that object store is making. However, several functions used in the implementation for `HttpService` on `reqwest::Client` (which I am essentially replicating, with the addition of the tracing) are private so I cannot reuse them in my implementation. 
   
   These are: 
   * `HttpError::reqwest`
   * `HttpRequestBody::into_reqwest`
   * `‎ClientOptions::client`
   
   **Describe the solution you'd like**
   These functions to be made `pub`. 
   
   **Describe alternatives you've considered**
   None, however, keen to hear if the there would be a better way to trace the calls. 
   
   **Additional context**
   N/A
   
   Happy to handle the PR for this (should be trivial), just wanted to make sure it was not misguided!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Expose several private functions to allow easier implemenation of `HttpService` and `HttpConnector` [arrow-rs-object-store]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #642:
URL: https://github.com/apache/arrow-rs-object-store/issues/642#issuecomment-3938545018

   Realistically we are unlikely to migrate away from reqwest, and so this is probably fine.
   
   Might be worth renaming `ClientOptions::client` to `ClientOptions::connect` or something though if we plan to expose it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Expose several private functions to allow easier implemenation of `HttpService` and `HttpConnector` [arrow-rs-object-store]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #642:
URL: https://github.com/apache/arrow-rs-object-store/issues/642#issuecomment-3900109531

   Have you considered wrapping the existing HttpConnector instead of duplicating it's functionality?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Expose several private functions to allow easier implemenation of `HttpService` and `HttpConnector` [arrow-rs-object-store]

Posted by "robalar (via GitHub)" <gi...@apache.org>.
robalar commented on issue #642:
URL: https://github.com/apache/arrow-rs-object-store/issues/642#issuecomment-3907769545

   @tustvold, yeah, the problem being that we already have exisiting implementations for our tracing that wrap reqwests `RequestBuilder`, so this is the type I want access to. If I were just to wrap the existing `HttpConnector`, I'd just have access to object stores `HttpRequest` - which I would need to add the same tracing to (which I _think_ would be do-able, just need to be able to set headers and see errors etc).
   
   However, having access to this methods would be the easiest and reduce maintanence burden for us, but you are obviously increasing your public surface area so its an increased burden for you. 
   
   Let me know what you think!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org