You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Matt <mi...@gmail.com> on 2016/01/20 03:28:26 UTC
Review Request 42536: Extend HAWQ service check to include querying
external table through PXF
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42536/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, and Newton Alex.
Bugs: AMBARI-14732
https://issues.apache.org/jira/browse/AMBARI-14732
Repository: ambari
Description
-------
Current HAWQ service check implementation executes tests with HAWQ internal tables. Extend the service check to include tests with external tables on HDFS, which can be queried through PXF
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py fe3743b
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py aa3527c
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py c35fdce
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py c1a38bb
Diff: https://reviews.apache.org/r/42536/diff/
Testing
-------
Manually Tested
Thanks,
Matt
Re: Review Request 42536: Extend HAWQ service check to include
querying external table through PXF
Posted by Matt <mi...@gmail.com>.
> On Jan. 20, 2016, 11:16 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py, line 74
> > <https://reviews.apache.org/r/42536/diff/2/?file=1203652#file1203652line74>
> >
> > there is utils.exec_hawq_operation() function that will source the path file and run a hawq command
The command **hawq state -d /hawq/master/directory** is supposed to be run on the HAWQ master host.
exec_hawq_operation runs the hawq command on the local host. Considering that Ambari picks any host with a HAWQ component, it is not guaranteed that it picks the HAWQMASTER host. In case HAWQSEGMENT host is picked (a host with no HAWQMASTER), we will need to ssh into the HAWQMASTER host and run the command. Hence we are using utils.exec_ssh_cmd for running this command
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42536/#review115582
-----------------------------------------------------------
On Jan. 20, 2016, 10:34 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42536/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 10:34 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-14732
> https://issues.apache.org/jira/browse/AMBARI-14732
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Current HAWQ service check implementation executes tests with HAWQ internal tables. Extend the service check to include tests with external tables on HDFS, which can be queried through PXF
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py fe3743b
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py aa3527c
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py c35fdce
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py c1a38bb
>
> Diff: https://reviews.apache.org/r/42536/diff/
>
>
> Testing
> -------
>
> Manually Tested
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42536: Extend HAWQ service check to include
querying external table through PXF
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42536/#review115582
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py (line 71)
<https://reviews.apache.org/r/42536/#comment176568>
there is utils.exec_hawq_operation() function that will source the path file and run a hawq command
- Alexander Denissov
On Jan. 20, 2016, 6:34 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42536/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 6:34 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-14732
> https://issues.apache.org/jira/browse/AMBARI-14732
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Current HAWQ service check implementation executes tests with HAWQ internal tables. Extend the service check to include tests with external tables on HDFS, which can be queried through PXF
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py fe3743b
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py aa3527c
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py c35fdce
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py c1a38bb
>
> Diff: https://reviews.apache.org/r/42536/diff/
>
>
> Testing
> -------
>
> Manually Tested
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42536: Extend HAWQ service check to include
querying external table through PXF
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42536/#review115698
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py (line 63)
<https://reviews.apache.org/r/42536/#comment176715>
Why gpadmin user is hardcoded? Shouldn't we use hawq_constants.hawq_user variable instead?
- Oleksandr Diachenko
On Jan. 20, 2016, 6:34 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42536/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 6:34 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-14732
> https://issues.apache.org/jira/browse/AMBARI-14732
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Current HAWQ service check implementation executes tests with HAWQ internal tables. Extend the service check to include tests with external tables on HDFS, which can be queried through PXF
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py fe3743b
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py aa3527c
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py c35fdce
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py c1a38bb
>
> Diff: https://reviews.apache.org/r/42536/diff/
>
>
> Testing
> -------
>
> Manually Tested
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42536: Extend HAWQ service check to include
querying external table through PXF
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42536/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 3:13 p.m.)
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, and Newton Alex.
Bugs: AMBARI-14732
https://issues.apache.org/jira/browse/AMBARI-14732
Repository: ambari
Description
-------
Current HAWQ service check implementation executes tests with HAWQ internal tables. Extend the service check to include tests with external tables on HDFS, which can be queried through PXF
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py fe3743b
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py aa3527c
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py c35fdce
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py c1a38bb
Diff: https://reviews.apache.org/r/42536/diff/
Testing
-------
Manually Tested
Thanks,
Matt
Re: Review Request 42536: Extend HAWQ service check to include
querying external table through PXF
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42536/#review115657
-----------------------------------------------------------
Ship it!
Ship It!
- Lav Jain
On Jan. 20, 2016, 6:34 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42536/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 6:34 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-14732
> https://issues.apache.org/jira/browse/AMBARI-14732
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Current HAWQ service check implementation executes tests with HAWQ internal tables. Extend the service check to include tests with external tables on HDFS, which can be queried through PXF
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py fe3743b
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py aa3527c
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py c35fdce
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py c1a38bb
>
> Diff: https://reviews.apache.org/r/42536/diff/
>
>
> Testing
> -------
>
> Manually Tested
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42536: Extend HAWQ service check to include
querying external table through PXF
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42536/#review115571
-----------------------------------------------------------
Ship it!
Ship It!
- bhuvnesh chaudhary
On Jan. 20, 2016, 6:34 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42536/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 6:34 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-14732
> https://issues.apache.org/jira/browse/AMBARI-14732
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Current HAWQ service check implementation executes tests with HAWQ internal tables. Extend the service check to include tests with external tables on HDFS, which can be queried through PXF
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py fe3743b
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py aa3527c
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py c35fdce
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py c1a38bb
>
> Diff: https://reviews.apache.org/r/42536/diff/
>
>
> Testing
> -------
>
> Manually Tested
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42536: Extend HAWQ service check to include
querying external table through PXF
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42536/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 10:34 a.m.)
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, and Newton Alex.
Bugs: AMBARI-14732
https://issues.apache.org/jira/browse/AMBARI-14732
Repository: ambari
Description
-------
Current HAWQ service check implementation executes tests with HAWQ internal tables. Extend the service check to include tests with external tables on HDFS, which can be queried through PXF
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py fe3743b
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py aa3527c
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/service_check.py c35fdce
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py c1a38bb
Diff: https://reviews.apache.org/r/42536/diff/
Testing
-------
Manually Tested
Thanks,
Matt