You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/15 21:04:20 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #9149: fix:
adhoc metric bug in chord diagram
villebro opened a new pull request #9149: fix: adhoc metric bug in chord diagram
URL: https://github.com/apache/incubator-superset/pull/9149
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
The chord viz currently doesn't work with ad-hoc metrics due to the metric being replaced by the metric name.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TEST PLAN
Tested locally. Unit tests not added due to planned refactoring of `viz.py` in the near future.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: closes #8977
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@hefeng11725 @mtomov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda merged pull request #9149: fix:
adhoc metric bug in chord diagram
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9149: fix: adhoc metric bug in chord diagram
URL: https://github.com/apache/incubator-superset/pull/9149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9149: fix:
adhoc metric bug in chord diagram
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9149: fix: adhoc metric bug in chord diagram
URL: https://github.com/apache/incubator-superset/pull/9149#issuecomment-586641781
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9149?src=pr&el=h1) Report
> Merging [#9149](https://codecov.io/gh/apache/incubator-superset/pull/9149?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f95a8677423eb5515c13d466a395329e158ab9b6?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9149?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9149 +/- ##
=======================================
Coverage 59.06% 59.06%
=======================================
Files 372 372
Lines 11922 11922
Branches 2919 2919
=======================================
Hits 7042 7042
Misses 4698 4698
Partials 182 182
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9149?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9149?src=pr&el=footer). Last update [f95a867...ba1461d](https://codecov.io/gh/apache/incubator-superset/pull/9149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org