You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/22 14:13:23 UTC

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1645: test: enhanced test stability

guoqqqi opened a new pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   - Related issues
   related #1605  #1633  #1634
   ___
   fixed CI error: 
   Update front-end E2E tests to enhance stability based on CI errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1645: test: enhanced test stability

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645#discussion_r598843463



##########
File path: web/cypress/integration/service/edit-service-with-upstream.spec.js
##########
@@ -25,8 +25,7 @@ context('Edit Service with Upstream', () => {
   });
 
   it('should create a test upstream', function () {
-    cy.visit('/');
-    cy.contains('Upstream').click();
+    cy.visit('/upstream/list');

Review comment:
       Is it necessary to add `cy.get(this.domSelector.empty).should('be.visible');` to make sure the upstream list rendered well just like https://github.com/apache/apisix-dashboard/pull/1645/files#diff-e5538d6ea581a815051ee7ba013803f5b5c795e4979f908e3aa8c51844521a36R34 ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1645: test: enhanced test stability

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645#issuecomment-804283336


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=h1) Report
   > Merging [#1645](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=desc) (13970e8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/85efb37b0c5fe76c94a85f9fc0dc13312083181d?el=desc) (85efb37) will **decrease** coverage by `4.93%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1645      +/-   ##
   ==========================================
   - Coverage   72.38%   67.45%   -4.94%     
   ==========================================
     Files         134       47      -87     
     Lines        5737     3116    -2621     
     Branches      665        0     -665     
   ==========================================
   - Hits         4153     2102    -2051     
   + Misses       1341      767     -574     
   - Partials      243      247       +4     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `48.04% <ø> (+0.32%)` | :arrow_up: |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (-1.21%)` | :arrow_down: |
   | ... and [88 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=footer). Last update [85efb37...13970e8](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1645: test: enhanced test stability

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645#discussion_r598927311



##########
File path: web/cypress/integration/service/edit-service-with-upstream.spec.js
##########
@@ -25,8 +25,7 @@ context('Edit Service with Upstream', () => {
   });
 
   it('should create a test upstream', function () {
-    cy.visit('/');
-    cy.contains('Upstream').click();
+    cy.visit('/upstream/list');

Review comment:
       Agree with you




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] LiteSun merged pull request #1645: test: enhanced test stability

Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1645: test: enhanced test stability

Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645#discussion_r599243319



##########
File path: web/cypress/integration/consumer/create_and_delete_consumer.spec.js
##########
@@ -25,10 +25,9 @@ context('Create and Delete Consumer', () => {
   });
 
   it('creates consumer with key-auth', function () {
-    cy.visit('/');
-    cy.contains('Consumer').click();
+    cy.visit('/consumer/list');

Review comment:
       This will not cover whether the left menu button can jump to the corresponding page. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io commented on pull request #1645: test: enhanced test stability

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645#issuecomment-804283336


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=h1) Report
   > Merging [#1645](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=desc) (13970e8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/85efb37b0c5fe76c94a85f9fc0dc13312083181d?el=desc) (85efb37) will **decrease** coverage by `24.34%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1645       +/-   ##
   ===========================================
   - Coverage   72.38%   48.04%   -24.35%     
   ===========================================
     Files         134       47       -87     
     Lines        5737     3116     -2621     
     Branches      665        0      -665     
   ===========================================
   - Hits         4153     1497     -2656     
   + Misses       1341     1334        -7     
   - Partials      243      285       +42     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `48.04% <ø> (+0.32%)` | :arrow_up: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: |
   | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
   | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: |
   | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: |
   | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `57.22% <0.00%> (-31.93%)` | :arrow_down: |
   | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: |
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `51.83% <0.00%> (-26.94%)` | :arrow_down: |
   | ... and [105 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=footer). Last update [85efb37...13970e8](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org