You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "peterxcli (via GitHub)" <gi...@apache.org> on 2025/03/16 03:00:43 UTC
[PR] HDDS-11799. Remove hdds.scm.safemode.pipeline-availability.check property [ozone]
peterxcli opened a new pull request, #8095:
URL: https://github.com/apache/ozone/pull/8095
## What changes were proposed in this pull request?
The Pipeline creation logic has changed a lot from the time "hdds.scm.safemode.pipeline-availability.check" property was introduced. Now we create the pipelines in background, so the Pipeline Rule will not block safemode exit even in a fresh cluster.
This property is not need now.
This is why this property was added : [Since in a real cluster we may not have a open pipeline in beginning, this rule should be turned off by default.](https://issues.apache.org/jira/browse/HDDS-642?focusedCommentId=16701147&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16701147%C2%A0)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11799
## How was this patch tested?
CI:
https://github.com/peterxcli/ozone/actions/runs/13878915745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11799. Remove hdds.scm.safemode.pipeline-availability.check property [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on code in PR #8095:
URL: https://github.com/apache/ozone/pull/8095#discussion_r2031147010
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineReportHandler.java:
##########
@@ -140,9 +131,7 @@ protected void processPipelineReport(PipelineReport report,
}
}
if (pipeline.isHealthy()) {
- if (pipelineAvailabilityCheck && scmSafeModeManager.getInSafeMode()) {
Review Comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11799. Remove hdds.scm.safemode.pipeline-availability.check property [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8095:
URL: https://github.com/apache/ozone/pull/8095#issuecomment-2785914251
Thanks @peterxcli for the patch, @aryangupta1998 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11799. Remove hdds.scm.safemode.pipeline-availability.check property [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #8095:
URL: https://github.com/apache/ozone/pull/8095#issuecomment-2785916816
Thanks @aryangupta1998 for the review, @adoroszlai for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11799. Remove hdds.scm.safemode.pipeline-availability.check property [ozone]
Posted by "aryangupta1998 (via GitHub)" <gi...@apache.org>.
aryangupta1998 commented on code in PR #8095:
URL: https://github.com/apache/ozone/pull/8095#discussion_r2029554492
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineReportHandler.java:
##########
@@ -140,9 +131,7 @@ protected void processPipelineReport(PipelineReport report,
}
}
if (pipeline.isHealthy()) {
- if (pipelineAvailabilityCheck && scmSafeModeManager.getInSafeMode()) {
Review Comment:
I think we should retain the scmSafeModeManager.getInSafeMode() check and only remove pipelineAvailabilityCheck.
Without the safemode check, SCMEvents.OPEN_PIPELINE will be fired every time a DN sends a report to SCM—even when SCM is not in safemode. While this may not have a functional impact (since HealthyPipelineSafeModeRule#onMessage() also checks for safemode before acting), it leads to unnecessary event publishing and processing.
Keeping the safemode check avoids this overhead and keeps the event flow cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11799. Remove hdds.scm.safemode.pipeline-availability.check property [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8095:
URL: https://github.com/apache/ozone/pull/8095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org