You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "linliu-code (via GitHub)" <gi...@apache.org> on 2025/07/27 01:58:26 UTC

[PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

linliu-code opened a new pull request, #13631:
URL: https://github.com/apache/hudi/pull/13631

   ### Change Logs
   
   Added some tests for:
   
   * Full schema merge
     * Event time based
       * normal pass
         * deltaMerge
         * finalMerge 
       * ignore_defaults
         * deltaMerge
         * finalMerge 
       * ignore_markers 
          * deltaMerge
         * finalMerge  
     * Commit time based 
       * the same set as event time 
       
   * Partial schema merger (keep_values mode)
     * Event time base
       * old has full schema, new has few columns
       * old and new have some set of columns 
     * Commit time base 
       * old has full schema, new has few columns
       * old and new have some set of columns 
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124922941

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219",
       "triggerID" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * 1ced73aa58c10582e751a4c4115d231b26def294 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216) 
   * f10604f4c2c8264cd79db34583af8c6132686357 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3123893169

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3125273040

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219",
       "triggerID" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8817425bc4493a7223247cd6f7f8ca591bd69de4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7222",
       "triggerID" : "8817425bc4493a7223247cd6f7f8ca591bd69de4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * 8817425bc4493a7223247cd6f7f8ca591bd69de4 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7222) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124494567

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71a7235cc133d94c86f84eacae4c553985cd68ea Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198) 
   * 5602b982151ba87a258fefaf184e2cc506b523fb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124797107

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124466787

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191) 
   * 71a7235cc133d94c86f84eacae4c553985cd68ea UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3123816724

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1405307a041843009388e455a3a049f209966132 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190) 
   * 2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124805639

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124849472

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * 1ced73aa58c10582e751a4c4115d231b26def294 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216) 
   * f10604f4c2c8264cd79db34583af8c6132686357 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124955166

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219",
       "triggerID" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8817425bc4493a7223247cd6f7f8ca591bd69de4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8817425bc4493a7223247cd6f7f8ca591bd69de4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * 1ced73aa58c10582e751a4c4115d231b26def294 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216) 
   * f10604f4c2c8264cd79db34583af8c6132686357 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219) 
   * 8817425bc4493a7223247cd6f7f8ca591bd69de4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124467965

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191) 
   * 71a7235cc133d94c86f84eacae4c553985cd68ea Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13631:
URL: https://github.com/apache/hudi/pull/13631#discussion_r2234201210


##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestBufferedRecordMerger.java:
##########
@@ -0,0 +1,747 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.functional;
+
+import org.apache.hudi.AvroConversionUtils;
+import org.apache.hudi.DefaultSparkRecordMerger;
+import org.apache.hudi.OverwriteWithLatestSparkRecordMerger;
+import org.apache.hudi.common.config.RecordMergeMode;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.DeleteRecord;
+import org.apache.hudi.common.model.HoodieEmptyRecord;
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.model.HoodieRecordMerger;
+import org.apache.hudi.common.model.HoodieSparkRecord;
+import org.apache.hudi.common.table.HoodieTableConfig;
+import org.apache.hudi.common.table.PartialUpdateMode;
+import org.apache.hudi.common.table.log.InstantRange;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.expression.Predicate;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.testutils.SparkClientFunctionalTestHarness;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.spark.sql.catalyst.InternalRow;
+import org.apache.spark.sql.catalyst.expressions.GenericInternalRow;
+import org.apache.spark.sql.types.StructType;
+import org.apache.spark.unsafe.types.UTF8String;
+import org.jetbrains.annotations.Nullable;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.function.UnaryOperator;
+
+import static org.apache.hudi.BaseSparkInternalRowReaderContext.getFieldValueFromInternalRow;
+import static org.apache.hudi.common.config.RecordMergeMode.COMMIT_TIME_ORDERING;
+import static org.apache.hudi.common.table.HoodieTableConfig.PARTIAL_UPDATE_CUSTOM_MARKER;
+import static org.apache.hudi.common.util.OrderingValues.DEFAULT_VALUE;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class TestBufferedRecordMerger extends SparkClientFunctionalTestHarness {
+  private static final String RECORD_KEY = "initial_id";
+  private static final String PARTITION_PATH = "test_partition";
+  private static final long ORDERING_VALUE = 100L;
+  private static final String IGNORE_MARKERS_VALUE = "__HUDI_DEFAULT_MARKER__";
+  private static final List<Schema> schemas = Arrays.asList(
+      getSchema1(), getSchema2(), getSchema3(), getSchema4(), getSchema5());
+  private static final Schema readerSchema = getSchema1();
+  private HoodieTableConfig tableConfig;
+  private StorageConfiguration<?> storageConfig;
+  private TypedProperties props;
+  private HoodieReaderContext<InternalRow> readerContext;
+
+  @BeforeEach
+  void setUp() throws IOException {
+    // Setup mocks
+    tableConfig = mock(HoodieTableConfig.class);
+    storageConfig = mock(StorageConfiguration.class);
+    when(tableConfig.getPayloadClass()).thenReturn(
+        "org.apache.hudi.common.model.DefaultHoodieRecordPayload");
+    when(tableConfig.populateMetaFields()).thenReturn(false);
+    when(tableConfig.getRecordKeyFields()).thenReturn(Option.of(new String[]{"id"}));
+
+    // Create reader context.
+    props = new TypedProperties();
+    readerContext = new DummyInternalRowReaderContext(
+        storageConfig, tableConfig, Option.empty(), Option.empty());
+  }
+
+  // ============================================================================
+  // Test Set 1: enablePartialMerging = false
+  // ============================================================================
+  @ParameterizedTest
+  @EnumSource(value = RecordMergeMode.class, names = {"COMMIT_TIME_ORDERING", "EVENT_TIME_ORDERING"})
+  void testRegularMerging(RecordMergeMode mergeMode) throws IOException {
+    // Test 1: NONE partial update mode (regular path)
+    BufferedRecordMerger<InternalRow> noneMerger = createMerger(readerContext, mergeMode, PartialUpdateMode.NONE);
+    // Create records with all columns
+    InternalRow oldRecord = createFullRecord("old_id", "Old Name", 25, "Old City", 1000L);
+    InternalRow newRecord = createFullRecord("new_id", "New Name", 30, "New City", 2000L);
+    BufferedRecord<InternalRow> oldBufferedRecord =
+        new BufferedRecord<>(RECORD_KEY, ORDERING_VALUE, oldRecord, 1, false);
+    BufferedRecord<InternalRow> newBufferedRecord =
+        new BufferedRecord<>(RECORD_KEY, ORDERING_VALUE - 1, newRecord, 1, false);

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3125068139

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219",
       "triggerID" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8817425bc4493a7223247cd6f7f8ca591bd69de4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7222",
       "triggerID" : "8817425bc4493a7223247cd6f7f8ca591bd69de4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * f10604f4c2c8264cd79db34583af8c6132686357 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219) 
   * 8817425bc4493a7223247cd6f7f8ca591bd69de4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7222) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124803827

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3123812833

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1405307a041843009388e455a3a049f209966132 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #13631:
URL: https://github.com/apache/hudi/pull/13631#discussion_r2234025977


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/PartialUpdateStrategy.java:
##########
@@ -78,8 +81,12 @@ BufferedRecord<T> partialMerge(BufferedRecord<T> newRecord,
       case FILL_DEFAULTS:
         return newRecord;
       case IGNORE_DEFAULTS:
-        return reconcileDefaultValues(
-            newRecord, oldRecord, newSchema, oldSchema, keepOldMetadataColumns);
+        try {
+          return reconcileDefaultValues(
+              newRecord, oldRecord, newSchema, oldSchema, keepOldMetadataColumns);
+        } catch (IOException e) {
+          throw new HoodieException("Failed to merge two records", e);

Review Comment:
   why no move the try catch within `reconcileDefaultValues` 



##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestBufferedRecordMerger.java:
##########
@@ -0,0 +1,747 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.functional;
+
+import org.apache.hudi.AvroConversionUtils;
+import org.apache.hudi.DefaultSparkRecordMerger;
+import org.apache.hudi.OverwriteWithLatestSparkRecordMerger;
+import org.apache.hudi.common.config.RecordMergeMode;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.DeleteRecord;
+import org.apache.hudi.common.model.HoodieEmptyRecord;
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.model.HoodieRecordMerger;
+import org.apache.hudi.common.model.HoodieSparkRecord;
+import org.apache.hudi.common.table.HoodieTableConfig;
+import org.apache.hudi.common.table.PartialUpdateMode;
+import org.apache.hudi.common.table.log.InstantRange;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.expression.Predicate;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.testutils.SparkClientFunctionalTestHarness;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.spark.sql.catalyst.InternalRow;
+import org.apache.spark.sql.catalyst.expressions.GenericInternalRow;
+import org.apache.spark.sql.types.StructType;
+import org.apache.spark.unsafe.types.UTF8String;
+import org.jetbrains.annotations.Nullable;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.function.UnaryOperator;
+
+import static org.apache.hudi.BaseSparkInternalRowReaderContext.getFieldValueFromInternalRow;
+import static org.apache.hudi.common.config.RecordMergeMode.COMMIT_TIME_ORDERING;
+import static org.apache.hudi.common.table.HoodieTableConfig.PARTIAL_UPDATE_CUSTOM_MARKER;
+import static org.apache.hudi.common.util.OrderingValues.DEFAULT_VALUE;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class TestBufferedRecordMerger extends SparkClientFunctionalTestHarness {
+  private static final String RECORD_KEY = "initial_id";
+  private static final String PARTITION_PATH = "test_partition";
+  private static final long ORDERING_VALUE = 100L;
+  private static final String IGNORE_MARKERS_VALUE = "__HUDI_DEFAULT_MARKER__";
+  private static final List<Schema> schemas = Arrays.asList(
+      getSchema1(), getSchema2(), getSchema3(), getSchema4(), getSchema5());
+  private static final Schema readerSchema = getSchema1();
+  private HoodieTableConfig tableConfig;
+  private StorageConfiguration<?> storageConfig;
+  private TypedProperties props;
+  private HoodieReaderContext<InternalRow> readerContext;
+
+  @BeforeEach
+  void setUp() throws IOException {
+    // Setup mocks
+    tableConfig = mock(HoodieTableConfig.class);
+    storageConfig = mock(StorageConfiguration.class);
+    when(tableConfig.getPayloadClass()).thenReturn(
+        "org.apache.hudi.common.model.DefaultHoodieRecordPayload");
+    when(tableConfig.populateMetaFields()).thenReturn(false);
+    when(tableConfig.getRecordKeyFields()).thenReturn(Option.of(new String[]{"id"}));
+
+    // Create reader context.
+    props = new TypedProperties();
+    readerContext = new DummyInternalRowReaderContext(
+        storageConfig, tableConfig, Option.empty(), Option.empty());
+  }
+
+  // ============================================================================
+  // Test Set 1: enablePartialMerging = false
+  // ============================================================================
+  @ParameterizedTest
+  @EnumSource(value = RecordMergeMode.class, names = {"COMMIT_TIME_ORDERING", "EVENT_TIME_ORDERING"})
+  void testRegularMerging(RecordMergeMode mergeMode) throws IOException {
+    // Test 1: NONE partial update mode (regular path)
+    BufferedRecordMerger<InternalRow> noneMerger = createMerger(readerContext, mergeMode, PartialUpdateMode.NONE);
+    // Create records with all columns
+    InternalRow oldRecord = createFullRecord("old_id", "Old Name", 25, "Old City", 1000L);
+    InternalRow newRecord = createFullRecord("new_id", "New Name", 30, "New City", 2000L);
+    BufferedRecord<InternalRow> oldBufferedRecord =
+        new BufferedRecord<>(RECORD_KEY, ORDERING_VALUE, oldRecord, 1, false);
+    BufferedRecord<InternalRow> newBufferedRecord =
+        new BufferedRecord<>(RECORD_KEY, ORDERING_VALUE - 1, newRecord, 1, false);

Review Comment:
   for regular updates, lets test both cases. 
   - new record has higher ordering value. 
   - new record has lower ordering value 
   
   looks like we are testing only for lower ordering value. 
   
   Also, lets do the above for both `deltaMerge` and `finalMerge` 
   



##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestBufferedRecordMerger.java:
##########
@@ -0,0 +1,747 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.functional;
+
+import org.apache.hudi.AvroConversionUtils;
+import org.apache.hudi.DefaultSparkRecordMerger;
+import org.apache.hudi.OverwriteWithLatestSparkRecordMerger;
+import org.apache.hudi.common.config.RecordMergeMode;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.DeleteRecord;
+import org.apache.hudi.common.model.HoodieEmptyRecord;
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.model.HoodieRecordMerger;
+import org.apache.hudi.common.model.HoodieSparkRecord;
+import org.apache.hudi.common.table.HoodieTableConfig;
+import org.apache.hudi.common.table.PartialUpdateMode;
+import org.apache.hudi.common.table.log.InstantRange;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.expression.Predicate;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.testutils.SparkClientFunctionalTestHarness;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.IndexedRecord;
+import org.apache.spark.sql.catalyst.InternalRow;
+import org.apache.spark.sql.catalyst.expressions.GenericInternalRow;
+import org.apache.spark.sql.types.StructType;
+import org.apache.spark.unsafe.types.UTF8String;
+import org.jetbrains.annotations.Nullable;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.function.UnaryOperator;
+
+import static org.apache.hudi.BaseSparkInternalRowReaderContext.getFieldValueFromInternalRow;
+import static org.apache.hudi.common.config.RecordMergeMode.COMMIT_TIME_ORDERING;
+import static org.apache.hudi.common.table.HoodieTableConfig.PARTIAL_UPDATE_CUSTOM_MARKER;
+import static org.apache.hudi.common.util.OrderingValues.DEFAULT_VALUE;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class TestBufferedRecordMerger extends SparkClientFunctionalTestHarness {
+  private static final String RECORD_KEY = "initial_id";
+  private static final String PARTITION_PATH = "test_partition";
+  private static final long ORDERING_VALUE = 100L;
+  private static final String IGNORE_MARKERS_VALUE = "__HUDI_DEFAULT_MARKER__";
+  private static final List<Schema> schemas = Arrays.asList(
+      getSchema1(), getSchema2(), getSchema3(), getSchema4(), getSchema5());
+  private static final Schema readerSchema = getSchema1();
+  private HoodieTableConfig tableConfig;
+  private StorageConfiguration<?> storageConfig;
+  private TypedProperties props;
+  private HoodieReaderContext<InternalRow> readerContext;
+
+  @BeforeEach
+  void setUp() throws IOException {
+    // Setup mocks
+    tableConfig = mock(HoodieTableConfig.class);
+    storageConfig = mock(StorageConfiguration.class);
+    when(tableConfig.getPayloadClass()).thenReturn(
+        "org.apache.hudi.common.model.DefaultHoodieRecordPayload");
+    when(tableConfig.populateMetaFields()).thenReturn(false);
+    when(tableConfig.getRecordKeyFields()).thenReturn(Option.of(new String[]{"id"}));
+
+    // Create reader context.
+    props = new TypedProperties();
+    readerContext = new DummyInternalRowReaderContext(
+        storageConfig, tableConfig, Option.empty(), Option.empty());
+  }
+
+  // ============================================================================
+  // Test Set 1: enablePartialMerging = false
+  // ============================================================================
+  @ParameterizedTest
+  @EnumSource(value = RecordMergeMode.class, names = {"COMMIT_TIME_ORDERING", "EVENT_TIME_ORDERING"})
+  void testRegularMerging(RecordMergeMode mergeMode) throws IOException {
+    // Test 1: NONE partial update mode (regular path)
+    BufferedRecordMerger<InternalRow> noneMerger = createMerger(readerContext, mergeMode, PartialUpdateMode.NONE);
+    // Create records with all columns
+    InternalRow oldRecord = createFullRecord("old_id", "Old Name", 25, "Old City", 1000L);
+    InternalRow newRecord = createFullRecord("new_id", "New Name", 30, "New City", 2000L);
+    BufferedRecord<InternalRow> oldBufferedRecord =
+        new BufferedRecord<>(RECORD_KEY, ORDERING_VALUE, oldRecord, 1, false);
+    BufferedRecord<InternalRow> newBufferedRecord =
+        new BufferedRecord<>(RECORD_KEY, ORDERING_VALUE - 1, newRecord, 1, false);

Review Comment:
   Let me list the cases we wanted to cover here. 
   
   ```
   for each (Event time based merge mode, CommitTime based merge mode){
        for each (deltaMerge, finalMerge) {
              case 1: old record valid w/ ordering value 100, new record is valid w/ ordering value 200. (new has higher ordering value)
              case 2: old record valid w/ ordering value 100, new record is valid w/ ordering value 50. (new has lower ordering value)
              case 3: old record valid w/ ordering value 100, new record is valid w/ no ordering value. (new has no ordering value)
              case 4: old record valid w/ no ordering value, new record is valid w/ ordering value 200. (old no ordering value, new has a valid ordering value)
              case 5: old record valid w/ no ordering value, new record is valid w/ no ordering value. (old no ordering value, new has no ordering value)
              case 6: old record valid w/ ordering value 100, new record is deleted w/ no ordering value (new record is deleted)
              case 7: old record valid w/ ordering value 100, new record is deleted w/ higher ordering value 200 (new record is deleted w/ higher ordering value)
              case 8: old record valid w/ ordering value 100, new record is deleted w/ lower ordering value 50 (new record is deleted w/ lower ordering value)
              case 9: old record is deleted w/ no ordering value, new record is valid w/ no ordering value (old record is deleted)
              case 10: old record is deleted w/ no ordering value, new record is valid w/ a valid ordering value (old record is deleted, new w/ valid ordering value)
              case 11: old record is deleted w/ no ordering value, new record is also deleted (old record is deleted, new is also deleted)
              case 12: old record is deleted w/ ordering value 100, new record is valid w/ no ordering value (old record is deleted)
              case 13: old record is deleted w/ ordering value 100, new record is valid w/ a valid ordering value 200 (old record is deleted, new w/ valid ordering value)
              case 14: old record is deleted w/ ordering value 100, new record is valid w/ a lower ordering value 50 (old record is deleted, new w/ lower ordering value)
              case 15: old record is deleted w/ ordering value 100, new record is also deleted (old record is deleted, new is also deleted)
       }
   }
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124793582

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124493650

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191) 
   * 71a7235cc133d94c86f84eacae4c553985cd68ea Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198) 
   * 5602b982151ba87a258fefaf184e2cc506b523fb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3123759378

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1405307a041843009388e455a3a049f209966132 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3123757015

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1405307a041843009388e455a3a049f209966132 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3123817641

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1405307a041843009388e455a3a049f209966132 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190) 
   * 2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124504904

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71a7235cc133d94c86f84eacae4c553985cd68ea Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198) 
   * 5602b982151ba87a258fefaf184e2cc506b523fb Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124851639

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * 1ced73aa58c10582e751a4c4115d231b26def294 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216) 
   * f10604f4c2c8264cd79db34583af8c6132686357 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124791045

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5602b982151ba87a258fefaf184e2cc506b523fb Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201) 
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124569753

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5602b982151ba87a258fefaf184e2cc506b523fb Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #13631:
URL: https://github.com/apache/hudi/pull/13631


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124792817

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5602b982151ba87a258fefaf184e2cc506b523fb Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201) 
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124790174

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5602b982151ba87a258fefaf184e2cc506b523fb Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201) 
   * 66d934580f83c7f7a492f966c07900ae4eaa444f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #13631:
URL: https://github.com/apache/hudi/pull/13631#discussion_r2234179594


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/PartialUpdateStrategy.java:
##########
@@ -78,8 +81,12 @@ BufferedRecord<T> partialMerge(BufferedRecord<T> newRecord,
       case FILL_DEFAULTS:
         return newRecord;
       case IGNORE_DEFAULTS:
-        return reconcileDefaultValues(
-            newRecord, oldRecord, newSchema, oldSchema, keepOldMetadataColumns);
+        try {
+          return reconcileDefaultValues(
+              newRecord, oldRecord, newSchema, oldSchema, keepOldMetadataColumns);
+        } catch (IOException e) {
+          throw new HoodieException("Failed to merge two records", e);

Review Comment:
   removed it since it is not needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124835351

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * 1ced73aa58c10582e751a4c4115d231b26def294 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124822751

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 66d934580f83c7f7a492f966c07900ae4eaa444f Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213) 
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * 1ced73aa58c10582e751a4c4115d231b26def294 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13631:
URL: https://github.com/apache/hudi/pull/13631#discussion_r2234249994


##########
hudi-common/src/main/java/org/apache/hudi/common/util/OrderingValues.java:
##########
@@ -27,7 +27,7 @@
  * Factory class for ordering values.
  */
 public class OrderingValues {
-  private static final Comparable<?> DEFAULT_VALUE = org.apache.hudi.common.model.HoodieRecord.DEFAULT_ORDERING_VALUE;
+  public static final Comparable<?> DEFAULT_VALUE = org.apache.hudi.common.model.HoodieRecord.DEFAULT_ORDERING_VALUE;

Review Comment:
   We make it private intentially and let's always use `OrderingValues.getDefault()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-9650] Add tests for BufferedRecordMerger [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13631:
URL: https://github.com/apache/hudi/pull/13631#issuecomment-3124960189

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1405307a041843009388e455a3a049f209966132",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7190",
       "triggerID" : "1405307a041843009388e455a3a049f209966132",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7191",
       "triggerID" : "2363d9f6ba4a8efb21bc28f1bfc3b44436cd147e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7198",
       "triggerID" : "71a7235cc133d94c86f84eacae4c553985cd68ea",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7201",
       "triggerID" : "5602b982151ba87a258fefaf184e2cc506b523fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7213",
       "triggerID" : "66d934580f83c7f7a492f966c07900ae4eaa444f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f6209945ad846309fcd15a8f74f1897c0082dbfe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4a1b93ed67155b8201a4c510e812e5d705be7b9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "38d185b5add6051aa1bc5033d0d3cc8099a6c5b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7216",
       "triggerID" : "1ced73aa58c10582e751a4c4115d231b26def294",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219",
       "triggerID" : "f10604f4c2c8264cd79db34583af8c6132686357",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8817425bc4493a7223247cd6f7f8ca591bd69de4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8817425bc4493a7223247cd6f7f8ca591bd69de4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6ebc2909e05ae7e0a202fe6727a62a0e1ea78a8 UNKNOWN
   * f6209945ad846309fcd15a8f74f1897c0082dbfe UNKNOWN
   * 4a1b93ed67155b8201a4c510e812e5d705be7b9d UNKNOWN
   * 38d185b5add6051aa1bc5033d0d3cc8099a6c5b0 UNKNOWN
   * f10604f4c2c8264cd79db34583af8c6132686357 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7219) 
   * 8817425bc4493a7223247cd6f7f8ca591bd69de4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org