[GitHub] [commons-imaging] kinow commented on pull request #303: IMAGING-322: ImageFormat uses a list for extensions instead of array

["kinow (via GitHub)" <gi...@apache.org>]

kinow commented on PR #303:
URL: https://github.com/apache/commons-imaging/pull/303#issuecomment-1646294422

   >@gwlucastrig @kinow Any thoughts on array vs. set vs. list?
   
   Sorry, a bit out of the loop. I think Imaging adopts arrays in some places for performance, but there could be some other reason too (e.g. directly translation from C/Python without thinking too hard about lists vs. arrays, or simply copied what was already done in other parts of the code).
   
   IMHO, consistency is also important. So if lists are used here, users would probably expect to find the extensions as lists in other parts, and maybe similar concepts in Imaging. But if there are parsers/utilities/etc still using arrays… then I'd have a wider look and confirm it really makes sense and also create an issue to plan & discuss (also in the ml list) switching.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org