[GitHub] zeppelin pull request #2884: trim property name of interpreter settings

[rockiee281 <gi...@git.apache.org>]

GitHub user rockiee281 opened a pull request:

    https://github.com/apache/zeppelin/pull/2884

    trim property name of interpreter settings

    ### What is this PR for?
    trim property name of interpreter settings
    
    ### What type of PR is it?
    Improvement 
    
    ### Todos
    * [x] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3335
    
    
    ### How should this be tested?
    * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
    * Strongly recommended: add automated unit tests for any new or changed behavior
    * Outline any manual steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rockiee281/zeppelin ZEPPELIN-3335-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2884
    
----

----


---

[GitHub] zeppelin issue #2884: trim property name of interpreter settings

[rockiee281 <gi...@git.apache.org>]

Github user rockiee281 commented on the issue:

    https://github.com/apache/zeppelin/pull/2884
  
    Hi, @r-kamath  the duplicated PR closed now。 Please review this PR. thanks


---

[GitHub] zeppelin pull request #2884: trim property name of interpreter settings

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2884


---

[GitHub] zeppelin issue #2884: trim property name of interpreter settings

[jongyoul <gi...@git.apache.org>]

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2884
  
    I've found a bug in this PR. if the value is not a string, it occurs error. e.g.
    
    ```
    "zeppelin.python": {
              "name": "zeppelin.python",
              "value": "python",
              "type": "string"
            },
    ```
    
    our properties look like this.


---

[GitHub] zeppelin issue #2884: trim property name of interpreter settings

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2884
  
    LGTM, will merge if no more comments


---

[GitHub] zeppelin issue #2884: trim property name of interpreter settings

[r-kamath <gi...@git.apache.org>]

Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/2884
  
    @rockiee281 Thanks for the update PR
    Please close #2870 


---