You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/01/21 22:47:45 UTC

[jira] Created: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

MapReduce tests don't compile following HDFS-1561
-------------------------------------------------

                 Key: MAPREDUCE-2282
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
             Project: Hadoop Map/Reduce
          Issue Type: Bug
            Reporter: Tom White
            Priority: Blocker


TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985003#action_12985003 ] 

Tsz Wo (Nicholas), SZE commented on MAPREDUCE-2282:
---------------------------------------------------

Sure, either way is good.

BTW, thanks for reporting this bug.

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993928#comment-12993928 ] 

Hudson commented on MAPREDUCE-2282:
-----------------------------------

Integrated in Hadoop-Mapreduce-22-branch #33 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/])
    

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Assignee: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: TestMRPorts.patch
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated MAPREDUCE-2282:
-------------------------------------------

    Attachment: TestMRPorts.patch

This should fix the build.
It used to be one test before project split therefore the dependency.
I reduced the dependencies, but did not eliminate them completely. 
Basically it needs to start and stop NN and DN, which can be done using MiniDFSCluter instead of using TestHDFSServerPorts methods. Another jira?

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: TestMRPorts.patch
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985007#action_12985007 ] 

Tom White commented on MAPREDUCE-2282:
--------------------------------------

Thanks Nicholas. I don't think I'll have time to produce a fix today, so if someone else wants to pick this up that would be good.

We could detect these kinds of errors by getting hudson to compile all three subprojects whenever it runs tests for one of them. Does that sound like a good change to make?

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016906#comment-13016906 ] 

Hudson commented on MAPREDUCE-2282:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #643 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/])
    

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Assignee: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: TestMRPorts.patch
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-2282:
----------------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Konstantin!

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Assignee: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: TestMRPorts.patch
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984979#action_12984979 ] 

Tsz Wo (Nicholas), SZE commented on MAPREDUCE-2282:
---------------------------------------------------

It would be great if we can remove the dependence.

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated MAPREDUCE-2282:
---------------------------------

    Fix Version/s: 0.22.0

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984986#action_12984986 ] 

Tom White commented on MAPREDUCE-2282:
--------------------------------------

Sorry, meant to say "I'm _not_ sure how feasible it is to remove the dependency".

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984987#action_12984987 ] 

Tsz Wo (Nicholas), SZE commented on MAPREDUCE-2282:
---------------------------------------------------

bq. I had a quick look and TestMRServerPorts tests things such as port clashes between the namenode and jobtracker, so I'm sure how feasible it is to remove the dependency.

Use the public APIs in HDFS but not the unstable HDFS test codes.  Does it sound impossible?

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-2282:
----------------------------------------------

    Hadoop Flags: [Reviewed]

+1 patch looks good.

I also tested it manually.  It fixes the build and TestMRServerPorts.

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Assignee: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: TestMRPorts.patch
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984985#action_12984985 ] 

Tom White commented on MAPREDUCE-2282:
--------------------------------------

I had a quick look and TestMRServerPorts tests things such as port clashes between the namenode and jobtracker, so I'm sure how feasible it is to remove the dependency. 

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko reassigned MAPREDUCE-2282:
----------------------------------------------

    Assignee: Konstantin Shvachko

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Assignee: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: TestMRPorts.patch
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated MAPREDUCE-2282:
-------------------------------------------

    Status: Patch Available  (was: Open)

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: TestMRPorts.patch
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-2282:
----------------------------------------------

    Component/s: test

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985212#action_12985212 ] 

Hudson commented on MAPREDUCE-2282:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #580 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/580/])
    MAPREDUCE-2282. Fix TestMRServerPorts for the changes in TestHDFSServerPorts.  Contributed by shv


> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Assignee: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: TestMRPorts.patch
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-2282) MapReduce tests don't compile following HDFS-1561

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985000#action_12985000 ] 

Tom White commented on MAPREDUCE-2282:
--------------------------------------

It's certainly possible to rely only on the public HDFS API by duplicating some of the functionality of TestHDFSServerPorts in TestMRServerPorts (such as startNameNode()). Alternatively, we could mark these methods as LimitedPrivate like we did in MiniDFSCluster. I'd be happy with either approach.

> MapReduce tests don't compile following HDFS-1561
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2282
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2282
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestMRServerPorts depends on TestHDFSServerPorts which was changed by HDFS-1561, resulting in a compilation failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.