You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2019/12/28 17:57:09 UTC
[groovy] branch GROOVY_3_0_X updated: Trivial refactoring: extract
constant array
This is an automated email from the ASF dual-hosted git repository.
sunlan pushed a commit to branch GROOVY_3_0_X
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/GROOVY_3_0_X by this push:
new 5e202e8 Trivial refactoring: extract constant array
5e202e8 is described below
commit 5e202e8394cb6c7e6fe719c5eb90b91cc9d9c538
Author: Daniel Sun <su...@apache.org>
AuthorDate: Sun Dec 29 01:56:07 2019 +0800
Trivial refactoring: extract constant array
(cherry picked from commit 17dee98d36dc16a1bea4ab7dd37c55e78281826f)
---
src/main/java/org/codehaus/groovy/vmplugin/v7/Selector.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/codehaus/groovy/vmplugin/v7/Selector.java b/src/main/java/org/codehaus/groovy/vmplugin/v7/Selector.java
index 1f1174f..a505580 100644
--- a/src/main/java/org/codehaus/groovy/vmplugin/v7/Selector.java
+++ b/src/main/java/org/codehaus/groovy/vmplugin/v7/Selector.java
@@ -501,6 +501,7 @@ public abstract class Selector {
* calls as well as getProperty calls.
*/
private static class MethodSelector extends Selector {
+ private static final Object[] SINGLE_NULL_ARRAY = { null };
protected MetaClass mc;
private boolean isCategoryMethod;
public MethodSelector(MutableCallSite callSite, Class sender, String methodName, CALL_TYPES callType, Boolean safeNavigation, Boolean thisCall, Boolean spreadCall, Object[] arguments) {
@@ -752,8 +753,7 @@ public abstract class Selector {
if (!isVargs) {
if (spread && useMetaClass) return;
if (params.length==2 && args.length==1) {
- //TODO: this Object[] can be constant
- handle = MethodHandles.insertArguments(handle, 1, new Object[]{null});
+ handle = MethodHandles.insertArguments(handle, 1, SINGLE_NULL_ARRAY);
}
return;
}