Re: [PR] Reject negative positional delete positions [iceberg-rust]

["CTTY (via GitHub)" <gi...@apache.org>]

CTTY commented on code in PR #2631:
URL: https://github.com/apache/iceberg-rust/pull/2631#discussion_r3502504836


##########
crates/iceberg/src/arrow/caching_delete_file_loader.rs:
##########
@@ -361,6 +361,13 @@ impl CachingDeleteFileLoader {
                     ));
                 };
 
+                if pos < 0 {
+                    return Err(Error::new(
+                        ErrorKind::DataInvalid,
+                        format!("negative position in delete file: {pos}"),

Review Comment:
   We should print file_path here as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org