[GitHub] [nifi] simonbence commented on a change in pull request #4411: NIFI-6312: Improved connection handling in AMQP processors

[GitBox <gi...@apache.org>]

simonbence commented on a change in pull request #4411:
URL: https://github.com/apache/nifi/pull/4411#discussion_r464113760



##########
File path: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPConsumer.java
##########
@@ -78,10 +74,15 @@ public void handleDelivery(final String consumerTag, final Envelope envelope, fi
     }
 
     // Visible for unit tests
-    protected Consumer getConsumer() {
+    Consumer getConsumer() {

Review comment:
       Minor: it is not used and neither was used before the change. Would it not make sense to remove?

##########
File path: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPRollbackException.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.amqp.processors;
+
+/**
+ * Exception to indicate an AMQP related error when the FlowFile should be tried to process again so the NiFi session should be rolled back.
+ */

Review comment:
       Minor: I think I do understand your reasons to introduce a second exception other than AMQPException and I do support it. It might worth to mention in the documentation that they are not interchangeable (thus in later times it will be not confusing that why this is not a subtype of the other.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org