You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/16 17:52:08 UTC

[GitHub] [trafficcontrol] zrhoffman opened a new pull request #4639: Use prebuilt images to build Traffic Control components

zrhoffman opened a new pull request #4639: Use prebuilt images to build Traffic Control components
URL: https://github.com/apache/trafficcontrol/pull/4639
 
 
   <!--
   ************ STOP!! ************
   If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   -->
   ## What does this PR (Pull Request) do?
   <!-- Explain the changes you made here. If this fixes an Issue, identify it by
   replacing the text in the checkbox item with the Issue number e.g.
   
   - [x] This PR fixes #9001 OR is not related to any Issue
   
   ^ This will automatically close Issue number 9001 when the Pull Request is
   merged (The '#' is important).
   
   Be sure you check the box properly, see the "The following criteria are ALL
   met by this PR" section for details.
   -->
   
   - [x] This PR:
       - Adds docker tags for prebuilt builder images to the build docker-compose.yml
       - is not related to any issue<!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
       
   Right now, building the RPMs requires first building the builder images, which takes 8.67 minutes on my Linux machine but almost certainly longer on MacOS. Since the builder images are mainly just yum installs, we can use prebuild Docker images without losing flexibility in terms of the code in each component.
   
   Besides time saved, the other benefit of using prebuilt builder images is that CI pipelines would no longer fail in cases where installing yum packages fails.
   
   I left the `build` fields in the docker-compose.yml for cases where someone wants to test a new builder image (e.g., new Go version).
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this
   Pull Request. Also, feel free to add the name of a tool or script that is
   affected but not on the list.
   
   Additionally, if this Pull Request does NOT affect documentation, please
   explain why documentation is not required. -->
   
   - Build system
   - Documentation
   - Grove
   - Traffic Monitor
   - Traffic Ops
   - Traffic Ops ORT
   - Traffic Portal
   - Traffic Router
   - Traffic Stats
   - Traffic Vault
   
   ## What is the best way to verify this PR?
   <!-- Please include here ALL the steps necessary to test your Pull Request. If
   it includes tests (and most should), outline here the steps needed to run the
   tests. If not, lay out the manual testing procedure and please explain why
   tests are unnecessary for this Pull Request. -->
   Run `./pkg -v` to verify that all of the components still build.
   
   ## The following criteria are ALL met by this PR
   <!-- Check the boxes to signify that the associated statement is true. To
   "check a box", replace the space inside of the square brackets with an 'x'.
   e.g.
   
   - [ x] <- Wrong
   - [x ] <- Wrong
   - [] <- Wrong
   - [*] <- Wrong
   - [x] <- Correct!
   
   -->
   - [x] Docker environment update, no tests necessary
   - [x] Builders are not mentioned in the documentation, no docs change necessary
   - [x] This PR includes an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] zrhoffman commented on issue #4639: Use prebuilt images to build Traffic Control components

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #4639: Use prebuilt images to build Traffic Control components
URL: https://github.com/apache/trafficcontrol/pull/4639#issuecomment-615347599
 
 
   > Ideally, we would have a jenkins job in place that rebuilds and updates the builder images every time a commit is merged to master.
   
   Docker Hub does this by default (and I just re-enabled it). Note that the build statuses are viewable under the :heavy_check_mark: or :x: [in the list of commits](https://github.com/zrhoffman/trafficcontrol/commits/master).
   
   You can also make it build for Git refs that match a certain regex.
   
   As you say, triggering webhooks with Jenkins would work, too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on issue #4639: Use prebuilt images to build Traffic Control components

Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #4639: Use prebuilt images to build Traffic Control components
URL: https://github.com/apache/trafficcontrol/pull/4639#issuecomment-615321445
 
 
   So, I'm kinda torn here, because I think this would be good, but it worries me that we don't really have an official supported process/automation for updating the builder images in the docker hub. Ideally, we would have a jenkins job in place that rebuilds and updates the builder images every time a commit is merged to master. Maybe we would also need images per official release (e.g. 4.0.x, 4.1.x, etc).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services