You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/07/31 23:02:31 UTC
[jira] Commented: (ZOOKEEPER-2) Synchronization issues in
QuorumPeer and FastLeader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618849#action_12618849 ]
Patrick Hunt commented on ZOOKEEPER-2:
--------------------------------------
PS, in future please use the <id>.patch naming scheme, ie. ZOOKEEPER-2.patch, thanks.
> Synchronization issues in QuorumPeer and FastLeader election
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-2
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Reporter: Benjamin Reed
> Assignee: Flavio Paiva Junqueira
> Attachments: patch-le-polish, patch-le-polish
>
>
> There are a couple of cases of member variables that need to be marked volatile or surrounded in a synchronization block. A couple of examples are:
> * QuorumPeer state should be synchronous
> * currentVote in QuorumPeer is marked volatile, but when it's members are often accessed individually as if they were in an atomic unit. Such code should be changed to get a reference to the currentVote and they access members through that reference.
> * It looks like logicalClock in FastLeaderElection should be volatile. It should either be fixed or commented to explain why it doesn't need to be.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.