You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by jun aoki <ja...@apache.org> on 2014/10/03 04:50:55 UTC
test-patch job available for Ambari project
Hi Ambari team,
The test-patch job that I have been working now started working.
(my ticket https://issues.apache.org/jira/browse/AMBARI-7209)
The test-patch Jenkins job location is here
https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/
What does it do for you (your ticket)?
The job takes a patch file from your Patch Available jira tickets, apply it
on the latest trunk, run tests and report back to your Jira ticket.
Example report here
https://issues.apache.org/jira/browse/AMBARI-7617
What's good then?
What the report tells you if your patch
1. is compatible with the latest trunk
2. passes all unit tests with the latest trunk
3. and a few good stuff ( like ASF license checks, etc)
*before* your patch goes into trunk.
This is a gate keeper to keep our trunk stable and clean!
Please note;
Currently patch files that are created by 'git diff trunk... > a.patch'
command are only accepted by the test-patch job. It is being reviewed at
the dev process proposal https://issues.apache.org/jira/browse/AMBARI-7476
--
-jun
Re: test-patch job available for Ambari project
Posted by jun aoki <ja...@apache.org>.
Hi Jonathan, good point.
Currently it is only about trunk. If a patch is meant for branch, but the
job does not distinguish.
We should be able to distinguish it through Affects Version/s field.
FYI: We will have a 1.7.0 commit job (build check after commit) though. It
is coming up as soon as 1.7.0 branch is cut.
On Fri, Oct 3, 2014 at 8:10 AM, Jonathan Hurley <jh...@hortonworks.com>
wrote:
> Thanks, Jun!
>
> Can you explain the workflow when a patch is made available for a branch
> (as opposed to trunk)? Will the system still attempt to apply the patch to
> trunk and report back that it failed, or will it just ignore the Patch
> Available?
>
> On Oct 3, 2014, at 10:06 AM, Yusaku Sako <yu...@hortonworks.com> wrote:
>
> > Thanks Jun.
> > This would help us a lot to enforce/maintain code quality.
> >
> > Yusaku
> >
> > On Thu, Oct 2, 2014 at 7:50 PM, jun aoki <ja...@apache.org> wrote:
> >> Hi Ambari team,
> >>
> >> The test-patch job that I have been working now started working.
> >> (my ticket https://issues.apache.org/jira/browse/AMBARI-7209)
> >>
> >> The test-patch Jenkins job location is here
> >>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/
> >>
> >>
> >> What does it do for you (your ticket)?
> >> The job takes a patch file from your Patch Available jira tickets,
> apply it
> >> on the latest trunk, run tests and report back to your Jira ticket.
> >> Example report here
> >> https://issues.apache.org/jira/browse/AMBARI-7617
> >>
> >>
> >> What's good then?
> >> What the report tells you if your patch
> >> 1. is compatible with the latest trunk
> >> 2. passes all unit tests with the latest trunk
> >> 3. and a few good stuff ( like ASF license checks, etc)
> >> *before* your patch goes into trunk.
> >>
> >> This is a gate keeper to keep our trunk stable and clean!
> >>
> >>
> >> Please note;
> >> Currently patch files that are created by 'git diff trunk... > a.patch'
> >> command are only accepted by the test-patch job. It is being reviewed at
> >> the dev process proposal
> https://issues.apache.org/jira/browse/AMBARI-7476
> >>
> >>
> >> --
> >> -jun
> >
> > --
> > CONFIDENTIALITY NOTICE
> > NOTICE: This message is intended for the use of the individual or entity
> to
> > which it is addressed and may contain information that is confidential,
> > privileged and exempt from disclosure under applicable law. If the reader
> > of this message is not the intended recipient, you are hereby notified
> that
> > any printing, copying, dissemination, distribution, disclosure or
> > forwarding of this communication is strictly prohibited. If you have
> > received this communication in error, please contact the sender
> immediately
> > and delete it from your system. Thank You.
>
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>
--
-jun
Re: test-patch job available for Ambari project
Posted by Jonathan Hurley <jh...@hortonworks.com>.
Thanks, Jun!
Can you explain the workflow when a patch is made available for a branch (as opposed to trunk)? Will the system still attempt to apply the patch to trunk and report back that it failed, or will it just ignore the Patch Available?
On Oct 3, 2014, at 10:06 AM, Yusaku Sako <yu...@hortonworks.com> wrote:
> Thanks Jun.
> This would help us a lot to enforce/maintain code quality.
>
> Yusaku
>
> On Thu, Oct 2, 2014 at 7:50 PM, jun aoki <ja...@apache.org> wrote:
>> Hi Ambari team,
>>
>> The test-patch job that I have been working now started working.
>> (my ticket https://issues.apache.org/jira/browse/AMBARI-7209)
>>
>> The test-patch Jenkins job location is here
>> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/
>>
>>
>> What does it do for you (your ticket)?
>> The job takes a patch file from your Patch Available jira tickets, apply it
>> on the latest trunk, run tests and report back to your Jira ticket.
>> Example report here
>> https://issues.apache.org/jira/browse/AMBARI-7617
>>
>>
>> What's good then?
>> What the report tells you if your patch
>> 1. is compatible with the latest trunk
>> 2. passes all unit tests with the latest trunk
>> 3. and a few good stuff ( like ASF license checks, etc)
>> *before* your patch goes into trunk.
>>
>> This is a gate keeper to keep our trunk stable and clean!
>>
>>
>> Please note;
>> Currently patch files that are created by 'git diff trunk... > a.patch'
>> command are only accepted by the test-patch job. It is being reviewed at
>> the dev process proposal https://issues.apache.org/jira/browse/AMBARI-7476
>>
>>
>> --
>> -jun
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: test-patch job available for Ambari project
Posted by Yusaku Sako <yu...@hortonworks.com>.
Thanks Jun.
This would help us a lot to enforce/maintain code quality.
Yusaku
On Thu, Oct 2, 2014 at 7:50 PM, jun aoki <ja...@apache.org> wrote:
> Hi Ambari team,
>
> The test-patch job that I have been working now started working.
> (my ticket https://issues.apache.org/jira/browse/AMBARI-7209)
>
> The test-patch Jenkins job location is here
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-test-patch/
>
>
> What does it do for you (your ticket)?
> The job takes a patch file from your Patch Available jira tickets, apply it
> on the latest trunk, run tests and report back to your Jira ticket.
> Example report here
> https://issues.apache.org/jira/browse/AMBARI-7617
>
>
> What's good then?
> What the report tells you if your patch
> 1. is compatible with the latest trunk
> 2. passes all unit tests with the latest trunk
> 3. and a few good stuff ( like ASF license checks, etc)
> *before* your patch goes into trunk.
>
> This is a gate keeper to keep our trunk stable and clean!
>
>
> Please note;
> Currently patch files that are created by 'git diff trunk... > a.patch'
> command are only accepted by the test-patch job. It is being reviewed at
> the dev process proposal https://issues.apache.org/jira/browse/AMBARI-7476
>
>
> --
> -jun
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.