[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #36681:
URL: https://github.com/apache/arrow/pull/36681#discussion_r1263680273


##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -387,6 +387,7 @@ takes precedence over ccache if a storage backend is configured" ON)
 (This is a deprecated option. Use CMake presets instead.)"
                 OFF
                 DEPENDS
+                ARROW_ACERO

Review Comment:
   Also, shouldn't we in theory _not_ rely on this in our own CI, given that it is a deprecated option?
   
   If the minimal python build needs this, then we should just enable ARROW_ACERO directly in that build? (or update it to not require acero)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org