You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by Brian LeRoux <b...@brian.io> on 2013/12/10 03:14:21 UTC

mocking in cordova.js

Where would I add a mock for XMLHttpRequest?

https://github.com/apache/cordova-js/pull/60/files

(Also: would you guys be cool w/ me refactoring cordova.js to use PhantomJS
instead of jsdom?)

Re: mocking in cordova.js

Posted by Brian LeRoux <b...@brian.io>.

Cool, if you don't mind reviewing my gruntfile refactor Andrew I'll tackle
this next.


On Tue, Dec 10, 2013 at 1:54 PM, Andrew Grieve <ag...@chromium.org> wrote:

> I'd be fine with PhantomJS. I had to not add a unit test to urlutil that I
> wanted to because jsdom didn't emulate things quite right.
>
>
> On Mon, Dec 9, 2013 at 9:14 PM, Brian LeRoux <b...@brian.io> wrote:
>
> > Where would I add a mock for XMLHttpRequest?
> >
> > https://github.com/apache/cordova-js/pull/60/files
> >
> > (Also: would you guys be cool w/ me refactoring cordova.js to use
> PhantomJS
> > instead of jsdom?)
> >
>

Re: mocking in cordova.js

Posted by Andrew Grieve <ag...@chromium.org>.

I'd be fine with PhantomJS. I had to not add a unit test to urlutil that I
wanted to because jsdom didn't emulate things quite right.

On Mon, Dec 9, 2013 at 9:14 PM, Brian LeRoux <b...@brian.io> wrote:

> Where would I add a mock for XMLHttpRequest?
>
> https://github.com/apache/cordova-js/pull/60/files
>
> (Also: would you guys be cool w/ me refactoring cordova.js to use PhantomJS
> instead of jsdom?)
>