You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by rahulforallp <gi...@git.apache.org> on 2018/02/22 13:02:18 UTC
[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...
GitHub user rahulforallp opened a pull request:
https://github.com/apache/carbondata/pull/1991
[CARBONDATA-2196]carbontable should be taken from loadmodel
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-2196
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1991
----
commit 72c7feace3a93b4cecde6beb9f17e983ea6912cb
Author: rahulforallp <ra...@...>
Date: 2018-02-22T12:59:57Z
carbontable should be taken from loadmodel
----
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1991
retest this please
---
[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1991
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1991
LGTM
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3863/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2775/
---
[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1991#discussion_r171748491
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -158,6 +160,27 @@ public static void createLocations(String[] locations) {
return localDataFolderLocArray;
}
+ /**
+ * This method will form the local data folder store location
+ *
+ * @param databaseName
+ * @param tableName
+ * @param taskId
+ * @param partitionId
+ * @param segmentId
+ * @param isCompactionFlow
+ * @param isAltPartitionFlow
+ * @return
+ */
+ public static String[] getLocalDataFolderLocation(String databaseName, String tableName,
+ String taskId, String partitionId, String segmentId, boolean isCompactionFlow,
+ boolean isAltPartitionFlow) {
+ CarbonTable carbonTable = CarbonMetadata.getInstance().getCarbonTable(databaseName, tableName);
+ return getLocalDataFolderLocation(carbonTable, tableName, taskId, partitionId,
+ segmentId, isCompactionFlow, isAltPartitionFlow);
+ }
+
--- End diff --
not required
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2574/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3932/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/1991
retest this please
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3929/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2596/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3841/
---
[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1991#discussion_r171487297
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] locations) {
}
}
}
+
/**
+ *
* This method will form the local data folder store location
*
- * @param databaseName
- * @param tableName
+ * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+ * @param isCompactionFlow
+ * @param isAltPartitionFlow
* @return
*/
- public static String[] getLocalDataFolderLocation(String databaseName, String tableName,
+ public static String[] getLocalDataFolderLocation(CarbonTable carbonTable, String tableName,
--- End diff --
not require tableName
---
[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1991#discussion_r171489212
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] locations) {
}
}
}
+
/**
+ *
* This method will form the local data folder store location
*
- * @param databaseName
- * @param tableName
+ * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+ * @param isCompactionFlow
+ * @param isAltPartitionFlow
* @return
*/
- public static String[] getLocalDataFolderLocation(String databaseName, String tableName,
+ public static String[] getLocalDataFolderLocation(CarbonTable carbonTable, String tableName,
--- End diff --
in case of Pre aggregate table, table name can be of child even though carbonTable object is for main table.
---
[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1991#discussion_r171750725
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -158,6 +160,27 @@ public static void createLocations(String[] locations) {
return localDataFolderLocArray;
}
+ /**
+ * This method will form the local data folder store location
+ *
+ * @param databaseName
+ * @param tableName
+ * @param taskId
+ * @param partitionId
+ * @param segmentId
+ * @param isCompactionFlow
+ * @param isAltPartitionFlow
+ * @return
+ */
+ public static String[] getLocalDataFolderLocation(String databaseName, String tableName,
+ String taskId, String partitionId, String segmentId, boolean isCompactionFlow,
+ boolean isAltPartitionFlow) {
+ CarbonTable carbonTable = CarbonMetadata.getInstance().getCarbonTable(databaseName, tableName);
+ return getLocalDataFolderLocation(carbonTable, tableName, taskId, partitionId,
+ segmentId, isCompactionFlow, isAltPartitionFlow);
+ }
+
--- End diff --
fixed
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2772/
---
[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1991#discussion_r170412687
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] locations) {
}
}
}
+
/**
+ *
* This method will form the local data folder store location
*
- * @param databaseName
- * @param tableName
+ * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+ * @param isCompactionFlow
+ * @param isAltPartitionFlow
* @return
*/
- public static String[] getLocalDataFolderLocation(String databaseName, String tableName,
+ public static String[] getLocalDataFolderLocation(CarbonTable carbonTable,
--- End diff --
Dont remove parameter tableName, you can remove databaseName, as in case of Pre aggregate table, table name can be of child even though carbonTable object is for main table
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1991
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3608/
---
[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1991#discussion_r170417245
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] locations) {
}
}
}
+
/**
+ *
* This method will form the local data folder store location
*
- * @param databaseName
- * @param tableName
+ * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+ * @param isCompactionFlow
+ * @param isAltPartitionFlow
* @return
*/
- public static String[] getLocalDataFolderLocation(String databaseName, String tableName,
+ public static String[] getLocalDataFolderLocation(CarbonTable carbonTable,
--- End diff --
done
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2618/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4006/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1991
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3703/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1991
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3644/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1991
LGTM
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4016/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2685/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3832/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1991
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3705/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2588/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/1991
retest this please
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2687/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4019/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3819/
---
[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1991
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2762/
---