You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2017/05/31 08:07:04 UTC
[jira] [Commented] (CAMEL-11369) camel-spring-boot-starter
generator paste incorrect default value
[ https://issues.apache.org/jira/browse/CAMEL-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030811#comment-16030811 ]
Claus Ibsen commented on CAMEL-11369:
-------------------------------------
Ah thanks, yeah for string, and possible int types, we should generate this a bit different.
Its down here we need to improve the code to check the type and deal with a bit different when its a String, int/long type and then use another initializer code
https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootAutoConfigurationMojo.java#L332
Mind that the code is repeated in several other places as well so do the same code changes there also. Maybe refactor into a reusable method as the enum generation code is more complicated than the simpler types.
I wonder if you want to take a stab at fixing this?
> camel-spring-boot-starter generator paste incorrect default value
> -----------------------------------------------------------------
>
> Key: CAMEL-11369
> URL: https://issues.apache.org/jira/browse/CAMEL-11369
> Project: Camel
> Issue Type: Bug
> Components: camel-spring-boot-starters, tooling
> Affects Versions: 2.20.0
> Reporter: Dmitry Volodin
> Fix For: 2.20.0
>
>
> I've created a new data component and submit it via PR
> https://github.com/apache/camel/pull/1729
> The spring-bootstarter *DataFormatConfiguration class contains incorrectly defined default value:
> private String contentTypeFormat = String.binary;
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)