You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/10/12 14:27:38 UTC

[GitHub] [ignite] NSAmelchev commented on a change in pull request #8350: IGNITE-13567 Fixed incorrect value of the joiningNodeClient flag

NSAmelchev commented on a change in pull request #8350:
URL: https://github.com/apache/ignite/pull/8350#discussion_r503333768



##########
File path: modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ClientImpl.java
##########
@@ -763,8 +763,13 @@ private static void sleepEx(long millis, Runnable before, Runnable after) throws
                         marshalCredentials(node);
                     }
 
-                    if (discoveryData == null)
-                        discoveryData = spi.collectExchangeData(new DiscoveryDataPacket(getLocalNodeId()));
+                    if (discoveryData == null) {
+                        DiscoveryDataPacket discoveryDataPacket = new DiscoveryDataPacket(getLocalNodeId());

Review comment:
       Lets rename to `dataPacket` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org