You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/28 15:12:59 UTC
[GitHub] [yunikorn-k8shim] pbacsko opened a new pull request, #492: [YUNIKORN-1410] Update user/group regex values in the defaults & test code
pbacsko opened a new pull request, #492:
URL: https://github.com/apache/yunikorn-k8shim/pull/492
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1410
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on a diff in pull request #492: [YUNIKORN-1410] Update user/group regex values in the defaults & test code
Posted by GitBox <gi...@apache.org>.
craigcondit commented on code in PR #492:
URL: https://github.com/apache/yunikorn-k8shim/pull/492#discussion_r1033736957
##########
pkg/plugin/admissioncontrollers/webhook/admission_controller_test.go:
##########
@@ -364,9 +364,9 @@ func prepareController(t *testing.T, url string, processNs string, bypassNs stri
conf.AMFilteringNoLabelNamespaces: noLabelNs,
conf.AMAccessControlBypassAuth: fmt.Sprintf("%t", bypassAuth),
conf.AMAccessControlTrustControllers: fmt.Sprintf("%t", trustControllers),
- conf.AMAccessControlSystemUsers: "system:serviceaccount:kube-system:job-controller",
- conf.AMAccessControlExternalUsers: "testExtUser",
- conf.AMAccessControlExternalGroups: "testExtGroup",
+ conf.AMAccessControlSystemUsers: "^system:serviceaccount:kube-system:job-controller",
Review Comment:
This should have a trailing '$'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #492: [YUNIKORN-1410] Update user/group regex values in the defaults & test code
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #492: [YUNIKORN-1410] Update user/group regex values in the defaults & test code
URL: https://github.com/apache/yunikorn-k8shim/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #492: [YUNIKORN-1410] Update user/group regex values in the defaults & test code
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #492:
URL: https://github.com/apache/yunikorn-k8shim/pull/492#issuecomment-1330398981
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#492](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b2ca3d) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/94537d13beab34344c16a148d3a8241db127c11c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94537d1) will **increase** coverage by `0.39%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
+ Coverage 67.11% 67.51% +0.39%
==========================================
Files 44 43 -1
Lines 7472 7459 -13
==========================================
+ Hits 5015 5036 +21
+ Misses 2268 2236 -32
+ Partials 189 187 -2
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lugin/admissioncontrollers/webhook/conf/am\_conf.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2NvbmYvYW1fY29uZi5nbw==) | `61.47% <ø> (ø)` | |
| [pkg/appmgmt/general/general.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwcG1nbXQvZ2VuZXJhbC9nZW5lcmFsLmdv) | `66.12% <100.00%> (ø)` | |
| [pkg/cache/context.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `39.86% <100.00%> (ø)` | |
| [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `89.09% <100.00%> (+10.59%)` | :arrow_up: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `74.21% <100.00%> (+10.31%)` | :arrow_up: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `61.69% <100.00%> (-1.52%)` | :arrow_down: |
| [pkg/common/utils/tg\_map.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy90Z19tYXAuZ28=) | | |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `76.22% <0.00%> (+1.39%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/492/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `75.36% <0.00%> (+3.39%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #492: [YUNIKORN-1410] Update user/group regex values in the defaults & test code
Posted by GitBox <gi...@apache.org>.
pbacsko commented on code in PR #492:
URL: https://github.com/apache/yunikorn-k8shim/pull/492#discussion_r1034547997
##########
pkg/plugin/admissioncontrollers/webhook/admission_controller_test.go:
##########
@@ -364,9 +364,9 @@ func prepareController(t *testing.T, url string, processNs string, bypassNs stri
conf.AMFilteringNoLabelNamespaces: noLabelNs,
conf.AMAccessControlBypassAuth: fmt.Sprintf("%t", bypassAuth),
conf.AMAccessControlTrustControllers: fmt.Sprintf("%t", trustControllers),
- conf.AMAccessControlSystemUsers: "system:serviceaccount:kube-system:job-controller",
- conf.AMAccessControlExternalUsers: "testExtUser",
- conf.AMAccessControlExternalGroups: "testExtGroup",
+ conf.AMAccessControlSystemUsers: "^system:serviceaccount:kube-system:job-controller",
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org