You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/23 05:38:18 UTC

[GitHub] [apisix] 840963657 commented on a diff in pull request #8374: fix: passive healthy code review.

840963657 commented on code in PR #8374:
URL: https://github.com/apache/apisix/pull/8374#discussion_r1030036297


##########
apisix/init.lua:
##########
@@ -724,6 +724,7 @@ local function healthcheck_passive(api_ctx)
                                            port or api_ctx.balancer_port,
                                            host,
                                            resp_status)
+                return

Review Comment:
   In the second loop, I think break and return have the same effect 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org