You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/10/07 08:40:29 UTC
[PR] refactor(services/gdrive): Use moka instead of Arc> [incubator-opendal]
Xuanwo opened a new pull request, #3234:
URL: https://github.com/apache/incubator-opendal/pull/3234
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(services/gdrive): Extract folder search logic [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3234:
URL: https://github.com/apache/incubator-opendal/pull/3234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(services/gdrive): Use moka instead of Arc> [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3234:
URL: https://github.com/apache/incubator-opendal/pull/3234#issuecomment-1751672897
`test_blocking_copy_file` always failed in CI but can't reproduce locally, I'm digging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(services/gdrive): Use moka instead of Arc> [incubator-opendal]
Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
Young-Flash commented on code in PR #3234:
URL: https://github.com/apache/incubator-opendal/pull/3234#discussion_r1349493985
##########
core/src/services/gdrive/core.rs:
##########
@@ -399,15 +411,9 @@ impl GdriveCore {
let url = format!("https://www.googleapis.com/drive/v3/files/{}", file_id);
- let source_abs_path = build_abs_path(&self.root, source);
- let mut source_parent: Vec<&str> = source_abs_path
- .split('/')
- .filter(|&x| !x.is_empty())
- .collect();
+ let mut source_parent: Vec<&str> = source.split('/').filter(|&x| !x.is_empty()).collect();
Review Comment:
maybe the missing `build_abs_path(&self.root, source)` cause the `unwrap()` on a `None` value in line 426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(services/gdrive): Use moka instead of Arc> [incubator-opendal]
Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
Young-Flash commented on code in PR #3234:
URL: https://github.com/apache/incubator-opendal/pull/3234#discussion_r1349493297
##########
core/src/services/gdrive/core.rs:
##########
@@ -417,7 +423,7 @@ impl GdriveCore {
let metadata = &json!({
"name": file_name,
- "removeParents": [cache.get(&source_parent.join("/")).unwrap().to_string()],
+ "removeParents": [self.cache_get(&source_parent.join("/")).unwrap().to_string()],
Review Comment:
seems something wrong here, [ci failed](https://github.com/apache/incubator-opendal/actions/runs/6440238781/job/17488852447?pr=3234#step:5:4538).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(services/gdrive): Use moka instead of Arc> [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3234:
URL: https://github.com/apache/incubator-opendal/pull/3234#issuecomment-1751663616
Maybe it's better for use to extract the path cache logic out of gdrive for better understanding and test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org