You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/05/19 14:35:50 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #4748: HDDS-8636. Containers in schema V1 fail for replication after the 1.3.0 upgrade
adoroszlai opened a new pull request, #4748:
URL: https://github.com/apache/ozone/pull/4748
## What changes were proposed in this pull request?
> @k5342 found a `NullPointerException` while replicating V1 containers in Ozone 1.3.0. V1 containers do not have the `schemaVersion` field in the `.container` file
The NPE is fixed by adding and using a comparison function that considers `null` and `V1` to be equal.
https://issues.apache.org/jira/browse/HDDS-8636
## How was this patch tested?
Tested in real cluster:
https://github.com/apache/ozone/pull/4723#issuecomment-1554645068
I'll try to add unit test and update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 merged pull request #4748: HDDS-8636. Containers in schema V1 fail for replication after the 1.3.0 upgrade
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #4748:
URL: https://github.com/apache/ozone/pull/4748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4748: HDDS-8636. Containers in schema V1 fail for replication after the 1.3.0 upgrade
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4748:
URL: https://github.com/apache/ozone/pull/4748#issuecomment-1557699380
Thanks @errose28 for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4748: HDDS-8636. Containers in schema V1 fail for replication after the 1.3.0 upgrade
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4748:
URL: https://github.com/apache/ozone/pull/4748#issuecomment-1555973597
Thanks @errose28 for the review.
> would you like to add more tests or do you think it is sufficient?
It turns out that there are some parameterized unit tests that are run for each schema version. Amended the list of versions with `null`, I think that should be fine for test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org