You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/12 10:57:09 UTC
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #802: allow adding docker Private registry details while deploying cluster
Pearl1594 opened a new pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-708381369
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#discussion_r503890497
##########
File path: src/views/compute/CreateKubernetesCluster.vue
##########
@@ -307,6 +366,7 @@ export default {
},
methods: {
fetchData () {
+ console.log(this.$store.getters.features)
Review comment:
not really needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#discussion_r504542379
##########
File path: src/components/view/ListView.vue
##########
@@ -439,7 +439,7 @@ export default {
value: this.editableValue
}).then(json => {
this.editableValueKey = null
-
+ this.$store.dispatch('RefreshFeatures')
Review comment:
@Pearl1594 why are we doing this here? Assuming we do list capabilities fetching already on log in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#discussion_r504546201
##########
File path: src/store/modules/user.js
##########
@@ -274,6 +274,16 @@ const user = {
reject(error)
})
})
+ },
+ RefreshFeatures ({ commit }) {
+ return new Promise((resolve, reject) => {
+ api('listCapabilities').then(response => {
+ const result = response.listcapabilitiesresponse.capability
+ commit('SET_FEATURES', result)
+ }).catch(error => {
Review comment:
@Pearl1594 Would not calling resolve after completion cause any issues ? (Promise state, GC, etc)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-707089102
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/802 (JID-3580)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-708380954
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-708387715
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/802 (JID-3587)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-707701365
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#discussion_r504546201
##########
File path: src/store/modules/user.js
##########
@@ -274,6 +274,16 @@ const user = {
reject(error)
})
})
+ },
+ RefreshFeatures ({ commit }) {
+ return new Promise((resolve, reject) => {
+ api('listCapabilities').then(response => {
+ const result = response.listcapabilitiesresponse.capability
+ commit('SET_FEATURES', result)
+ }).catch(error => {
Review comment:
@Pearl1594 Would not resolving the promise cause any issues ? (Promise state, GC, etc)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#discussion_r504543884
##########
File path: src/components/view/ListView.vue
##########
@@ -439,7 +439,7 @@ export default {
value: this.editableValue
}).then(json => {
this.editableValueKey = null
-
+ this.$store.dispatch('RefreshFeatures')
Review comment:
@rhtyd If this isn't done, then unless one logs out and logs back in or does a hard refresh, the store isn't going to be updated with the new value of 'kubernetesclusterexperimentalfeaturesenabled' in the capabilities list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-707705834
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/802 (JID-3582)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-707700745
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-707084264
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#discussion_r504546201
##########
File path: src/store/modules/user.js
##########
@@ -274,6 +274,16 @@ const user = {
reject(error)
})
})
+ },
+ RefreshFeatures ({ commit }) {
+ return new Promise((resolve, reject) => {
+ api('listCapabilities').then(response => {
+ const result = response.listcapabilitiesresponse.capability
+ commit('SET_FEATURES', result)
+ }).catch(error => {
Review comment:
@Pearl1594 Would not calling resolve after completion cause any issues ? (Promise state, GC, etc)
```suggestion
resolve()
}).catch(error => {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-707058475
Fixes https://github.com/apache/cloudstack-primate/issues/801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #802: allow adding docker Private registry details while deploying cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#issuecomment-707084780
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org