You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by jm...@apache.org on 2001/12/26 22:09:15 UTC

cvs commit: jakarta-turbine-fulcrum/src/services/java/org/apache/fulcrum/security/impl/db DBSecurityService.java

jmcnally    01/12/26 13:09:15

  Modified:    src/services/java/org/apache/fulcrum/security/impl/db
                        DBSecurityService.java
  Log:
  Why would you ALWAYS throw  an UnknownEntityException?  Is there a good
  reason for this, IMOHO it is not correct.  The same thing was being done for
  savePermission() and saveRole().  This will cause errors any time someone
  tries to update a Group.
  
  patch by Scott Weaver
  
  Revision  Changes    Path
  1.6       +4 -1      jakarta-turbine-fulcrum/src/services/java/org/apache/fulcrum/security/impl/db/DBSecurityService.java
  
  Index: DBSecurityService.java
  ===================================================================
  RCS file: /home/cvs/jakarta-turbine-fulcrum/src/services/java/org/apache/fulcrum/security/impl/db/DBSecurityService.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- DBSecurityService.java	2001/10/02 16:59:34	1.5
  +++ DBSecurityService.java	2001/12/26 21:09:15	1.6
  @@ -95,7 +95,7 @@
    * An implementation of SecurityService that uses a database as backend.
    *
    * @author <a href="mailto:Rafal.Krzewski@e-point.pl">Rafal Krzewski</a>
  - * @version $Id: DBSecurityService.java,v 1.5 2001/10/02 16:59:34 dlr Exp $
  + * @version $Id: DBSecurityService.java,v 1.6 2001/12/26 21:09:15 jmcnally Exp $
    */
   public class DBSecurityService
       extends BaseSecurityService
  @@ -656,6 +656,7 @@
               {
                   Criteria criteria = TurbineGroupPeer.buildCriteria(group);
                   TurbineGroupPeer.doUpdate(criteria);
  +                return;
               }
           }
           catch(Exception e)
  @@ -684,6 +685,7 @@
               {
                   Criteria criteria = TurbineRolePeer.buildCriteria(role);
                   TurbineRolePeer.doUpdate(criteria);
  +                return;
               }
           }
           catch(Exception e)
  @@ -713,6 +715,7 @@
               {
                   Criteria criteria = TurbinePermissionPeer.buildCriteria(permission);
                   TurbinePermissionPeer.doUpdate(criteria);
  +                return;
               }
           }
           catch(Exception e)
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>