You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/04 19:29:59 UTC

[GitHub] [commons-bcel] arturobernalg opened a new pull request #76: Minor Improvements:

arturobernalg opened a new pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76


   * Add final to variable
   * Use 'Map.computeIfAbsent'


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] garydgregory commented on pull request #76: Minor Improvements:

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76#issuecomment-773450583


   @arturobernalg 
   May you please rebase?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] garydgregory commented on a change in pull request #76: Minor Improvements:

Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76#discussion_r571025073



##########
File path: src/main/java/org/apache/bcel/classfile/Utility.java
##########
@@ -831,7 +831,7 @@ public static String signatureToString( final String signature, final boolean ch
         // Could be Class or Type...
         type = typeSignatureToString(signature.substring(index), chopit);
         index += unwrap(CONSUMER_CHARS); // update position
-        if ((typeParams.isEmpty()) && (index == signature.length())) {
+        if ((typeParams.length() == 0) && (index == signature.length())) {

Review comment:
       -1: Don't in-line `isEmpty()` calls.

##########
File path: src/main/java/org/apache/bcel/classfile/Utility.java
##########
@@ -1014,71 +1014,71 @@ public static String typeSignatureToString( final String signature, final boolea
                     // we have TypeArguments; build up partial result
                     // as we recurse for each TypeArgument
                     final StringBuilder type = new StringBuilder(compactClassName(signature.substring(1, bracketIndex), chopit)).append("<");
-                    int consumed_chars = bracketIndex + 1; // Shadows global var
+                    int CONSUMER_CHARS = bracketIndex + 1; // Shadows global var

Review comment:
       -1: don't upper case local vars.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] arturobernalg commented on pull request #76: Minor Improvements:

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76#issuecomment-773795390


   > @arturobernalg
   > May you please rebase?
   
   HI @garydgregory 
   
   Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] arturobernalg commented on a change in pull request #76: Minor Improvements:

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76#discussion_r571075894



##########
File path: src/main/java/org/apache/bcel/classfile/Utility.java
##########
@@ -831,7 +831,7 @@ public static String signatureToString( final String signature, final boolean ch
         // Could be Class or Type...
         type = typeSignatureToString(signature.substring(index), chopit);
         index += unwrap(CONSUMER_CHARS); // update position
-        if ((typeParams.isEmpty()) && (index == signature.length())) {
+        if ((typeParams.length() == 0) && (index == signature.length())) {

Review comment:
       :-( sorry, don't know what happen here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] arturobernalg closed pull request #76: Minor Improvements:

Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] arturobernalg commented on pull request #76: Minor Improvements:

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76#issuecomment-773795390


   > @arturobernalg
   > May you please rebase?
   
   HI @garydgregory 
   
   Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-bcel] garydgregory commented on pull request #76: Minor Improvements:

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76#issuecomment-773450583


   @arturobernalg 
   May you please rebase?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org