You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/07/18 17:04:59 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24711: fix: add format for timestamp in crdb to correctly use times values
codecov[bot] commented on PR #24711:
URL: https://github.com/apache/superset/pull/24711#issuecomment-1640620752
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24711?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24711](https://app.codecov.io/gh/apache/superset/pull/24711?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bddb697) into [master](https://app.codecov.io/gh/apache/superset/commit/0328dd270467e71260bfa85078beb7b38a87877b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0328dd2) will **decrease** coverage by `10.81%`.
> The diff coverage is `55.55%`.
> :exclamation: Current head bddb697 differs from pull request most recent head e77e7d4. Consider uploading reports for the commit e77e7d4 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24711 +/- ##
===========================================
- Coverage 68.97% 58.16% -10.81%
===========================================
Files 1901 1901
Lines 74008 74016 +8
Branches 8183 8183
===========================================
- Hits 51047 43055 -7992
- Misses 20840 28840 +8000
Partials 2121 2121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `54.01% <55.55%> (-0.01%)` | :arrow_down: |
| python | `60.85% <55.55%> (-22.61%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.83% <55.55%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24711?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/cockroachdb.py](https://app.codecov.io/gh/apache/superset/pull/24711?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NvY2tyb2FjaGRiLnB5) | `69.23% <55.55%> (-30.77%)` | :arrow_down: |
... and [293 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24711/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org