You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/08 06:07:00 UTC
[GitHub] [pulsar-helm-chart] czhfe opened a new pull request, #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
czhfe opened a new pull request, #342:
URL: https://github.com/apache/pulsar-helm-chart/pull/342
Fix PVC selector scope error when bookkeeper uses multiple data volumes
Fixes # Fix PVC selector scope error when bookkeeper uses multiple data volumes
### Motivation
Bookkeeper error when using multiple data volumes
### Modifications
Modify to the correct scope
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #342:
URL: https://github.com/apache/pulsar-helm-chart/pull/342#discussion_r1048067585
##########
charts/pulsar/templates/bookkeeper-statefulset.yaml:
##########
@@ -267,7 +267,7 @@ spec:
{{- if .storageClassName }}
storageClassName: "{{ .storageClassName }}"
{{- end }}
- {{- with .Values.bookkeeper.volumes.journal.selector }}
+ {{- with $.Values.bookkeeper.volumes.journal.selector }}
Review Comment:
Thanks for your contribution @czhfe. I am not familiar with this syntax. Do you have any documentation showing that this is the correct solution? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] czhfe commented on a diff in pull request #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
Posted by GitBox <gi...@apache.org>.
czhfe commented on code in PR #342:
URL: https://github.com/apache/pulsar-helm-chart/pull/342#discussion_r1048080911
##########
charts/pulsar/templates/bookkeeper-statefulset.yaml:
##########
@@ -267,7 +267,7 @@ spec:
{{- if .storageClassName }}
storageClassName: "{{ .storageClassName }}"
{{- end }}
- {{- with .Values.bookkeeper.volumes.journal.selector }}
+ {{- with $.Values.bookkeeper.volumes.journal.selector }}
Review Comment:
> Thanks for your contribution @czhfe. I am not familiar with this syntax. Do you have any documentation showing that this is the correct solution? Thanks!
We can check the official helm documentation for the `with` instructions
Here is the link: https://helm.sh/docs/chart_template_guide/control_structures/#modifying-scope-using-with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] johndlang commented on pull request #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
Posted by "johndlang (via GitHub)" <gi...@apache.org>.
johndlang commented on PR #342:
URL: https://github.com/apache/pulsar-helm-chart/pull/342#issuecomment-1400370958
When will this be merged ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall closed pull request #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall closed pull request #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
URL: https://github.com/apache/pulsar-helm-chart/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari merged pull request #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #342:
URL: https://github.com/apache/pulsar-helm-chart/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #342:
URL: https://github.com/apache/pulsar-helm-chart/pull/342#issuecomment-1493659712
Closing and opening to rerun tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] czhfe commented on pull request #342: Fix PVC selector scope error when bookkeeper uses multiple data volumes
Posted by "czhfe (via GitHub)" <gi...@apache.org>.
czhfe commented on PR #342:
URL: https://github.com/apache/pulsar-helm-chart/pull/342#issuecomment-1498357444
> Closing and opening to rerun tests.
Kind failed to initialize the kubernetes cluster during CI testing, please take a look at the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org