You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/19 13:23:30 UTC
[GitHub] [dubbo-go-pixiu] xiaoliu10 opened a new pull request #157: test Add reviewdog
xiaoliu10 opened a new pull request #157:
URL: https://github.com/apache/dubbo-go-pixiu/pull/157
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] kezhenxu94 commented on a change in pull request #157: test Add reviewdog
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #157:
URL: https://github.com/apache/dubbo-go-pixiu/pull/157#discussion_r615856491
##########
File path: .github/workflows/reviewdog.yml
##########
@@ -0,0 +1,16 @@
+name: reviewdog
+on: [pull_request]
+jobs:
+ golangci-lint:
+ name: runner / golangci-lint
Review comment:
The name is unnecessarily long, rename to `Review`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] kezhenxu94 commented on a change in pull request #157: test Add reviewdog
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #157:
URL: https://github.com/apache/dubbo-go-pixiu/pull/157#discussion_r615893180
##########
File path: .github/workflows/reviewdog.yml
##########
@@ -2,7 +2,7 @@ name: reviewdog
on: [pull_request]
jobs:
golangci-lint:
- name: runner / golangci-lint
+ name: runner / review
Review comment:
Why keep using "runner", I don't think it makes much sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] kezhenxu94 merged pull request #157: test Add reviewdog
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #157:
URL: https://github.com/apache/dubbo-go-pixiu/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] xiaoliu10 commented on a change in pull request #157: test Add reviewdog
Posted by GitBox <gi...@apache.org>.
xiaoliu10 commented on a change in pull request #157:
URL: https://github.com/apache/dubbo-go-pixiu/pull/157#discussion_r615866570
##########
File path: .github/workflows/reviewdog.yml
##########
@@ -0,0 +1,16 @@
+name: reviewdog
+on: [pull_request]
+jobs:
+ golangci-lint:
+ name: runner / golangci-lint
Review comment:
ok, i will
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] kezhenxu94 commented on a change in pull request #157: test Add reviewdog
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #157:
URL: https://github.com/apache/dubbo-go-pixiu/pull/157#discussion_r615897606
##########
File path: .github/workflows/reviewdog.yml
##########
@@ -0,0 +1,16 @@
+name: reviewdog
+on: [pull_request]
+jobs:
+ golangci-lint:
+ name: runner / review
Review comment:
```suggestion
name: review
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #157: test Add reviewdog
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #157:
URL: https://github.com/apache/dubbo-go-pixiu/pull/157#issuecomment-822535819
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#157](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b38b55e) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/60ed707059e32f1c16d49caba62512a08d32d4e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60ed707) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #157 +/- ##
========================================
Coverage 40.60% 40.60%
========================================
Files 35 35
Lines 1692 1692
========================================
Hits 687 687
Misses 903 903
Partials 102 102
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [60ed707...b38b55e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #157: test Add reviewdog
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #157:
URL: https://github.com/apache/dubbo-go-pixiu/pull/157#issuecomment-822535819
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#157](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b38b55e) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/60ed707059e32f1c16d49caba62512a08d32d4e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60ed707) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #157 +/- ##
========================================
Coverage 40.60% 40.60%
========================================
Files 35 35
Lines 1692 1692
========================================
Hits 687 687
Misses 903 903
Partials 102 102
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [60ed707...b38b55e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/157?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org