You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by Justin Mclean <jm...@apache.org> on 2019/09/03 22:34:22 UTC
Re: [DISCUSS] Git message guidelines
Hi,
Just out of interest what is the problem you're trying to solve here? It seem to me that doing something like this will make it harder for users to contribute, when you want to make it easier for them to do so.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org
Re: [DISCUSS] Git message guidelines
Posted by Ovilia <ov...@gmail.com>.
Yes, we would be appreciate such automatic tools only if it doesn't bring
much trouble to contributors.
If a commit message is not following the guidelines, the bot will comment
in the PR and ask the contributor to change the commit message. What
happens if the contributor doesn't change it for a long time?
Wenli
On Thu, Sep 5, 2019 at 10:19 AM Clement Ho <cl...@gitlab.com.invalid>
wrote:
> Actually you’d be surprised we have quite a number of community
> contributors and it’s growing each month.
>
> My concern is that adding these extra layers for the reviewer can make
> maintaining this project more tedious. As a maintainer for GitLab’s
> frontend code, I would highly recommend automating some of these things as
> it is easy to get a lot of PRs to review once the community picks up
> because majority contributors tend to miss these smaller details when
> contributing PRs.
>
> On Wed, Sep 4, 2019 at 9:15 PM Ovilia <ov...@gmail.com> wrote:
>
> > Hi Clement,
> >
> > Thanks for sharing information with us.
> > I suppose most of the committers in your projects at gitlab are all
> > employees so that there won't be a problem with frustrating community
> > contributors with compulsory changes when CI fails.
> > But this could be a problem for us, especially when we wish to encourage
> > more people to contribute.
> >
> > So I'd suggest our committers follow the guidelines, and make this
> > guideline informed to the community but do nothing compulsorily. We can
> > change the commit message when merging the PR in.
> >
> > Wenli
> >
> >
> > On Thu, Sep 5, 2019 at 8:48 AM Clement Ho <cl...@gitlab.com.invalid>
> > wrote:
> >
> > > We use danger bot at gitlab. It comments on the MR/PR and also fails
> the
> > > pipeline when something about the MR/PR is incomplete/incorrect
> > >
> > > On Tue, Sep 3, 2019 at 10:05 PM Ovilia <ov...@gmail.com> wrote:
> > >
> > > > Hi Clement,
> > > >
> > > > What's the process if we add this in CI?
> > > >
> > > > I was considering making these guidelines not compulsory for the
> > > community
> > > > to avoid the roundtrips as you mentioned, and the commit message can
> be
> > > > updated by who approved the pull request in the squashing stage.
> > > >
> > > > Wenli
> > > >
> > > >
> > > > On Wed, Sep 4, 2019 at 8:45 AM Clement Ho <clement@gitlab.com.invalid
> >
> > > > wrote:
> > > >
> > > > > I'm also concerned that this may create more roundtrips during code
> > > > reviews
> > > > > from the community (if we don't automate parts of it)
> > > > >
> > > > > On Tue, Sep 3, 2019 at 7:43 PM Willem Jiang <
> willem.jiang@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > I think providing the fix issue id is quite important for the
> > others
> > > > > > who want to dig the code.
> > > > > > The issue id could link to the discussion or some doc explain why
> > we
> > > > > > do this kind of change.
> > > > > > It's good practice to share the development context across the
> > > > community.
> > > > > >
> > > > > > It could be a pain for the first contributor to submit his first
> > PR,
> > > > > > but with the guide document will reduce that pain.
> > > > > >
> > > > > > Just my 2 cents.
> > > > > >
> > > > > > Willem Jiang
> > > > > >
> > > > > > Twitter: willemjiang
> > > > > > Weibo: 姜宁willem
> > > > > >
> > > > > > On Wed, Sep 4, 2019 at 6:40 AM Sheng Wu <
> wu.sheng.841108@gmail.com
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > Hi
> > > > > > >
> > > > > > > This kind of requirement should come from a high diversity and
> > very
> > > > > > active
> > > > > > > community, like the example your using.
> > > > > > > The only reason the commit log important, is because of quick
> > > review
> > > > > > update
> > > > > > > and revert in some critical case.
> > > > > > >
> > > > > > > From the commit log today, there is not that case.
> > > > > > > https://github.com/apache/incubator-echarts/commits/master
> > > > > > >
> > > > > > > I am supporting commit id as better as possible, but also, PPMC
> > > > please
> > > > > > > consider Justin's question/concern, don't make a higher bar
> than
> > > > > before.
> > > > > > >
> > > > > > > Sheng Wu 吴晟
> > > > > > >
> > > > > > > Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> > > > > > > Twitter, wusheng1108
> > > > > > >
> > > > > > >
> > > > > > > Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
> > > > > > >
> > > > > > > > Hi,
> > > > > > > > Just out of interest what is the problem you're trying to
> solve
> > > > here?
> > > > > > It
> > > > > > > > seem to me that doing something like this will make it harder
> > for
> > > > > > users to
> > > > > > > > contribute, when you want to make it easier for them to do
> so.
> > > > > > > > Thanks,
> > > > > > > > Justin
> > > > > > > >
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > > > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > > > > > >
> > > > > > > >
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Git message guidelines
Posted by Clement Ho <cl...@gitlab.com.INVALID>.
Actually you’d be surprised we have quite a number of community
contributors and it’s growing each month.
My concern is that adding these extra layers for the reviewer can make
maintaining this project more tedious. As a maintainer for GitLab’s
frontend code, I would highly recommend automating some of these things as
it is easy to get a lot of PRs to review once the community picks up
because majority contributors tend to miss these smaller details when
contributing PRs.
On Wed, Sep 4, 2019 at 9:15 PM Ovilia <ov...@gmail.com> wrote:
> Hi Clement,
>
> Thanks for sharing information with us.
> I suppose most of the committers in your projects at gitlab are all
> employees so that there won't be a problem with frustrating community
> contributors with compulsory changes when CI fails.
> But this could be a problem for us, especially when we wish to encourage
> more people to contribute.
>
> So I'd suggest our committers follow the guidelines, and make this
> guideline informed to the community but do nothing compulsorily. We can
> change the commit message when merging the PR in.
>
> Wenli
>
>
> On Thu, Sep 5, 2019 at 8:48 AM Clement Ho <cl...@gitlab.com.invalid>
> wrote:
>
> > We use danger bot at gitlab. It comments on the MR/PR and also fails the
> > pipeline when something about the MR/PR is incomplete/incorrect
> >
> > On Tue, Sep 3, 2019 at 10:05 PM Ovilia <ov...@gmail.com> wrote:
> >
> > > Hi Clement,
> > >
> > > What's the process if we add this in CI?
> > >
> > > I was considering making these guidelines not compulsory for the
> > community
> > > to avoid the roundtrips as you mentioned, and the commit message can be
> > > updated by who approved the pull request in the squashing stage.
> > >
> > > Wenli
> > >
> > >
> > > On Wed, Sep 4, 2019 at 8:45 AM Clement Ho <cl...@gitlab.com.invalid>
> > > wrote:
> > >
> > > > I'm also concerned that this may create more roundtrips during code
> > > reviews
> > > > from the community (if we don't automate parts of it)
> > > >
> > > > On Tue, Sep 3, 2019 at 7:43 PM Willem Jiang <wi...@gmail.com>
> > > > wrote:
> > > >
> > > > > I think providing the fix issue id is quite important for the
> others
> > > > > who want to dig the code.
> > > > > The issue id could link to the discussion or some doc explain why
> we
> > > > > do this kind of change.
> > > > > It's good practice to share the development context across the
> > > community.
> > > > >
> > > > > It could be a pain for the first contributor to submit his first
> PR,
> > > > > but with the guide document will reduce that pain.
> > > > >
> > > > > Just my 2 cents.
> > > > >
> > > > > Willem Jiang
> > > > >
> > > > > Twitter: willemjiang
> > > > > Weibo: 姜宁willem
> > > > >
> > > > > On Wed, Sep 4, 2019 at 6:40 AM Sheng Wu <wu.sheng.841108@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > > Hi
> > > > > >
> > > > > > This kind of requirement should come from a high diversity and
> very
> > > > > active
> > > > > > community, like the example your using.
> > > > > > The only reason the commit log important, is because of quick
> > review
> > > > > update
> > > > > > and revert in some critical case.
> > > > > >
> > > > > > From the commit log today, there is not that case.
> > > > > > https://github.com/apache/incubator-echarts/commits/master
> > > > > >
> > > > > > I am supporting commit id as better as possible, but also, PPMC
> > > please
> > > > > > consider Justin's question/concern, don't make a higher bar than
> > > > before.
> > > > > >
> > > > > > Sheng Wu 吴晟
> > > > > >
> > > > > > Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> > > > > > Twitter, wusheng1108
> > > > > >
> > > > > >
> > > > > > Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
> > > > > >
> > > > > > > Hi,
> > > > > > > Just out of interest what is the problem you're trying to solve
> > > here?
> > > > > It
> > > > > > > seem to me that doing something like this will make it harder
> for
> > > > > users to
> > > > > > > contribute, when you want to make it easier for them to do so.
> > > > > > > Thanks,
> > > > > > > Justin
> > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > > > > >
> > > > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Git message guidelines
Posted by Ovilia <ov...@gmail.com>.
Hi Clement,
Thanks for sharing information with us.
I suppose most of the committers in your projects at gitlab are all
employees so that there won't be a problem with frustrating community
contributors with compulsory changes when CI fails.
But this could be a problem for us, especially when we wish to encourage
more people to contribute.
So I'd suggest our committers follow the guidelines, and make this
guideline informed to the community but do nothing compulsorily. We can
change the commit message when merging the PR in.
Wenli
On Thu, Sep 5, 2019 at 8:48 AM Clement Ho <cl...@gitlab.com.invalid>
wrote:
> We use danger bot at gitlab. It comments on the MR/PR and also fails the
> pipeline when something about the MR/PR is incomplete/incorrect
>
> On Tue, Sep 3, 2019 at 10:05 PM Ovilia <ov...@gmail.com> wrote:
>
> > Hi Clement,
> >
> > What's the process if we add this in CI?
> >
> > I was considering making these guidelines not compulsory for the
> community
> > to avoid the roundtrips as you mentioned, and the commit message can be
> > updated by who approved the pull request in the squashing stage.
> >
> > Wenli
> >
> >
> > On Wed, Sep 4, 2019 at 8:45 AM Clement Ho <cl...@gitlab.com.invalid>
> > wrote:
> >
> > > I'm also concerned that this may create more roundtrips during code
> > reviews
> > > from the community (if we don't automate parts of it)
> > >
> > > On Tue, Sep 3, 2019 at 7:43 PM Willem Jiang <wi...@gmail.com>
> > > wrote:
> > >
> > > > I think providing the fix issue id is quite important for the others
> > > > who want to dig the code.
> > > > The issue id could link to the discussion or some doc explain why we
> > > > do this kind of change.
> > > > It's good practice to share the development context across the
> > community.
> > > >
> > > > It could be a pain for the first contributor to submit his first PR,
> > > > but with the guide document will reduce that pain.
> > > >
> > > > Just my 2 cents.
> > > >
> > > > Willem Jiang
> > > >
> > > > Twitter: willemjiang
> > > > Weibo: 姜宁willem
> > > >
> > > > On Wed, Sep 4, 2019 at 6:40 AM Sheng Wu <wu...@gmail.com>
> > > wrote:
> > > > >
> > > > > Hi
> > > > >
> > > > > This kind of requirement should come from a high diversity and very
> > > > active
> > > > > community, like the example your using.
> > > > > The only reason the commit log important, is because of quick
> review
> > > > update
> > > > > and revert in some critical case.
> > > > >
> > > > > From the commit log today, there is not that case.
> > > > > https://github.com/apache/incubator-echarts/commits/master
> > > > >
> > > > > I am supporting commit id as better as possible, but also, PPMC
> > please
> > > > > consider Justin's question/concern, don't make a higher bar than
> > > before.
> > > > >
> > > > > Sheng Wu 吴晟
> > > > >
> > > > > Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> > > > > Twitter, wusheng1108
> > > > >
> > > > >
> > > > > Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
> > > > >
> > > > > > Hi,
> > > > > > Just out of interest what is the problem you're trying to solve
> > here?
> > > > It
> > > > > > seem to me that doing something like this will make it harder for
> > > > users to
> > > > > > contribute, when you want to make it easier for them to do so.
> > > > > > Thanks,
> > > > > > Justin
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > > > >
> > > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Git message guidelines
Posted by Clement Ho <cl...@gitlab.com.INVALID>.
We use danger bot at gitlab. It comments on the MR/PR and also fails the
pipeline when something about the MR/PR is incomplete/incorrect
On Tue, Sep 3, 2019 at 10:05 PM Ovilia <ov...@gmail.com> wrote:
> Hi Clement,
>
> What's the process if we add this in CI?
>
> I was considering making these guidelines not compulsory for the community
> to avoid the roundtrips as you mentioned, and the commit message can be
> updated by who approved the pull request in the squashing stage.
>
> Wenli
>
>
> On Wed, Sep 4, 2019 at 8:45 AM Clement Ho <cl...@gitlab.com.invalid>
> wrote:
>
> > I'm also concerned that this may create more roundtrips during code
> reviews
> > from the community (if we don't automate parts of it)
> >
> > On Tue, Sep 3, 2019 at 7:43 PM Willem Jiang <wi...@gmail.com>
> > wrote:
> >
> > > I think providing the fix issue id is quite important for the others
> > > who want to dig the code.
> > > The issue id could link to the discussion or some doc explain why we
> > > do this kind of change.
> > > It's good practice to share the development context across the
> community.
> > >
> > > It could be a pain for the first contributor to submit his first PR,
> > > but with the guide document will reduce that pain.
> > >
> > > Just my 2 cents.
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Wed, Sep 4, 2019 at 6:40 AM Sheng Wu <wu...@gmail.com>
> > wrote:
> > > >
> > > > Hi
> > > >
> > > > This kind of requirement should come from a high diversity and very
> > > active
> > > > community, like the example your using.
> > > > The only reason the commit log important, is because of quick review
> > > update
> > > > and revert in some critical case.
> > > >
> > > > From the commit log today, there is not that case.
> > > > https://github.com/apache/incubator-echarts/commits/master
> > > >
> > > > I am supporting commit id as better as possible, but also, PPMC
> please
> > > > consider Justin's question/concern, don't make a higher bar than
> > before.
> > > >
> > > > Sheng Wu 吴晟
> > > >
> > > > Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> > > > Twitter, wusheng1108
> > > >
> > > >
> > > > Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
> > > >
> > > > > Hi,
> > > > > Just out of interest what is the problem you're trying to solve
> here?
> > > It
> > > > > seem to me that doing something like this will make it harder for
> > > users to
> > > > > contribute, when you want to make it easier for them to do so.
> > > > > Thanks,
> > > > > Justin
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > > >
> > > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > For additional commands, e-mail: dev-help@echarts.apache.org
> > >
> > >
> >
>
Re: [DISCUSS] Git message guidelines
Posted by Yi Shen <sh...@gmail.com>.
I think we are all agree about writing a commit message should not be a
trouble to our developers :)
Shuang's point is we should not block developer's commit because of
validation tool. And my point is we may use tools to help us writing a
clean commit message.
On Wed, Sep 4, 2019 at 11:05 AM Ovilia <ov...@gmail.com> wrote:
> Hi Clement,
>
> What's the process if we add this in CI?
>
> I was considering making these guidelines not compulsory for the community
> to avoid the roundtrips as you mentioned, and the commit message can be
> updated by who approved the pull request in the squashing stage.
>
> Wenli
>
>
> On Wed, Sep 4, 2019 at 8:45 AM Clement Ho <cl...@gitlab.com.invalid>
> wrote:
>
> > I'm also concerned that this may create more roundtrips during code
> reviews
> > from the community (if we don't automate parts of it)
> >
> > On Tue, Sep 3, 2019 at 7:43 PM Willem Jiang <wi...@gmail.com>
> > wrote:
> >
> > > I think providing the fix issue id is quite important for the others
> > > who want to dig the code.
> > > The issue id could link to the discussion or some doc explain why we
> > > do this kind of change.
> > > It's good practice to share the development context across the
> community.
> > >
> > > It could be a pain for the first contributor to submit his first PR,
> > > but with the guide document will reduce that pain.
> > >
> > > Just my 2 cents.
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Wed, Sep 4, 2019 at 6:40 AM Sheng Wu <wu...@gmail.com>
> > wrote:
> > > >
> > > > Hi
> > > >
> > > > This kind of requirement should come from a high diversity and very
> > > active
> > > > community, like the example your using.
> > > > The only reason the commit log important, is because of quick review
> > > update
> > > > and revert in some critical case.
> > > >
> > > > From the commit log today, there is not that case.
> > > > https://github.com/apache/incubator-echarts/commits/master
> > > >
> > > > I am supporting commit id as better as possible, but also, PPMC
> please
> > > > consider Justin's question/concern, don't make a higher bar than
> > before.
> > > >
> > > > Sheng Wu 吴晟
> > > >
> > > > Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> > > > Twitter, wusheng1108
> > > >
> > > >
> > > > Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
> > > >
> > > > > Hi,
> > > > > Just out of interest what is the problem you're trying to solve
> here?
> > > It
> > > > > seem to me that doing something like this will make it harder for
> > > users to
> > > > > contribute, when you want to make it easier for them to do so.
> > > > > Thanks,
> > > > > Justin
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > > >
> > > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > For additional commands, e-mail: dev-help@echarts.apache.org
> > >
> > >
> >
>
--
Yi Shen
Senior Developer
Baidu, Inc.
Re: [DISCUSS] Git message guidelines
Posted by Ovilia <ov...@gmail.com>.
Hi Clement,
What's the process if we add this in CI?
I was considering making these guidelines not compulsory for the community
to avoid the roundtrips as you mentioned, and the commit message can be
updated by who approved the pull request in the squashing stage.
Wenli
On Wed, Sep 4, 2019 at 8:45 AM Clement Ho <cl...@gitlab.com.invalid>
wrote:
> I'm also concerned that this may create more roundtrips during code reviews
> from the community (if we don't automate parts of it)
>
> On Tue, Sep 3, 2019 at 7:43 PM Willem Jiang <wi...@gmail.com>
> wrote:
>
> > I think providing the fix issue id is quite important for the others
> > who want to dig the code.
> > The issue id could link to the discussion or some doc explain why we
> > do this kind of change.
> > It's good practice to share the development context across the community.
> >
> > It could be a pain for the first contributor to submit his first PR,
> > but with the guide document will reduce that pain.
> >
> > Just my 2 cents.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Wed, Sep 4, 2019 at 6:40 AM Sheng Wu <wu...@gmail.com>
> wrote:
> > >
> > > Hi
> > >
> > > This kind of requirement should come from a high diversity and very
> > active
> > > community, like the example your using.
> > > The only reason the commit log important, is because of quick review
> > update
> > > and revert in some critical case.
> > >
> > > From the commit log today, there is not that case.
> > > https://github.com/apache/incubator-echarts/commits/master
> > >
> > > I am supporting commit id as better as possible, but also, PPMC please
> > > consider Justin's question/concern, don't make a higher bar than
> before.
> > >
> > > Sheng Wu 吴晟
> > >
> > > Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> > > Twitter, wusheng1108
> > >
> > >
> > > Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
> > >
> > > > Hi,
> > > > Just out of interest what is the problem you're trying to solve here?
> > It
> > > > seem to me that doing something like this will make it harder for
> > users to
> > > > contribute, when you want to make it easier for them to do so.
> > > > Thanks,
> > > > Justin
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > > For additional commands, e-mail: dev-help@echarts.apache.org
> > > >
> > > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > For additional commands, e-mail: dev-help@echarts.apache.org
> >
> >
>
Re: [DISCUSS] Git message guidelines
Posted by Clement Ho <cl...@gitlab.com.INVALID>.
I'm also concerned that this may create more roundtrips during code reviews
from the community (if we don't automate parts of it)
On Tue, Sep 3, 2019 at 7:43 PM Willem Jiang <wi...@gmail.com> wrote:
> I think providing the fix issue id is quite important for the others
> who want to dig the code.
> The issue id could link to the discussion or some doc explain why we
> do this kind of change.
> It's good practice to share the development context across the community.
>
> It could be a pain for the first contributor to submit his first PR,
> but with the guide document will reduce that pain.
>
> Just my 2 cents.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Wed, Sep 4, 2019 at 6:40 AM Sheng Wu <wu...@gmail.com> wrote:
> >
> > Hi
> >
> > This kind of requirement should come from a high diversity and very
> active
> > community, like the example your using.
> > The only reason the commit log important, is because of quick review
> update
> > and revert in some critical case.
> >
> > From the commit log today, there is not that case.
> > https://github.com/apache/incubator-echarts/commits/master
> >
> > I am supporting commit id as better as possible, but also, PPMC please
> > consider Justin's question/concern, don't make a higher bar than before.
> >
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> > Twitter, wusheng1108
> >
> >
> > Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
> >
> > > Hi,
> > > Just out of interest what is the problem you're trying to solve here?
> It
> > > seem to me that doing something like this will make it harder for
> users to
> > > contribute, when you want to make it easier for them to do so.
> > > Thanks,
> > > Justin
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > > For additional commands, e-mail: dev-help@echarts.apache.org
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> For additional commands, e-mail: dev-help@echarts.apache.org
>
>
Re: [DISCUSS] Git message guidelines
Posted by Willem Jiang <wi...@gmail.com>.
I think providing the fix issue id is quite important for the others
who want to dig the code.
The issue id could link to the discussion or some doc explain why we
do this kind of change.
It's good practice to share the development context across the community.
It could be a pain for the first contributor to submit his first PR,
but with the guide document will reduce that pain.
Just my 2 cents.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Wed, Sep 4, 2019 at 6:40 AM Sheng Wu <wu...@gmail.com> wrote:
>
> Hi
>
> This kind of requirement should come from a high diversity and very active
> community, like the example your using.
> The only reason the commit log important, is because of quick review update
> and revert in some critical case.
>
> From the commit log today, there is not that case.
> https://github.com/apache/incubator-echarts/commits/master
>
> I am supporting commit id as better as possible, but also, PPMC please
> consider Justin's question/concern, don't make a higher bar than before.
>
> Sheng Wu 吴晟
>
> Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> Twitter, wusheng1108
>
>
> Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
>
> > Hi,
> > Just out of interest what is the problem you're trying to solve here? It
> > seem to me that doing something like this will make it harder for users to
> > contribute, when you want to make it easier for them to do so.
> > Thanks,
> > Justin
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> > For additional commands, e-mail: dev-help@echarts.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org
Re: [DISCUSS] Git message guidelines
Posted by Sheng Wu <wu...@gmail.com>.
Hi
This kind of requirement should come from a high diversity and very active
community, like the example your using.
The only reason the commit log important, is because of quick review update
and revert in some critical case.
From the commit log today, there is not that case.
https://github.com/apache/incubator-echarts/commits/master
I am supporting commit id as better as possible, but also, PPMC please
consider Justin's question/concern, don't make a higher bar than before.
Sheng Wu 吴晟
Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108
Justin Mclean <jm...@apache.org> 于2019年9月3日周二 下午3:34写道：
> Hi,
> Just out of interest what is the problem you're trying to solve here? It
> seem to me that doing something like this will make it harder for users to
> contribute, when you want to make it easier for them to do so.
> Thanks,
> Justin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> For additional commands, e-mail: dev-help@echarts.apache.org
>
>