You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/06 07:40:09 UTC

[GitHub] [apisix] ychdesign opened a new issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

ychdesign opened a new issue #3988:
URL: https://github.com/apache/apisix/issues/3988


   ### Issue description
   {
     "count": 4000,
     "key": "server_addr",
     "policy": "redis-cluster",
     "redis_cluster_nodes": [],
     "rejected_code": 500,
     "time_window": 1
   }
   
   When the threshold not reached,a few requests are prevented by the limit-count plugin.
   The founction incoming, ttl and incrby opreations are not atomic.
   Maybe can use eval() to ensure it.
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):
   * OS (cmd: `uname -a`):
   * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   * apisix-dashboard version, if have:
   
   ### Minimal test code / Steps to reproduce the issue
   
   1. 
   2.
   3.
   
   ### What's the actual result? (including assertion message & call stack if applicable)
   
   ### What's the expected result?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] zwjzxh520 commented on issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
zwjzxh520 commented on issue #3988:
URL: https://github.com/apache/apisix/issues/3988#issuecomment-820871643


   不知道为什么会将这几行代码去掉？
   ` local ok, err = red:set_keepalive(10000, 100)
       if not ok then
           return nil, err
       end`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] ychdesign closed issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
ychdesign closed issue #3988:
URL: https://github.com/apache/apisix/issues/3988


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3988:
URL: https://github.com/apache/apisix/issues/3988#issuecomment-813944663


   You can open a draft PR.
   <img width="706" alt="微信截图_20210406164246" src="https://user-images.githubusercontent.com/4161644/113683770-27938580-96f7-11eb-994e-9fb0b2eae727.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] ychdesign commented on issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
ychdesign commented on issue #3988:
URL: https://github.com/apache/apisix/issues/3988#issuecomment-813975504


   thanks. It resloved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3988:
URL: https://github.com/apache/apisix/issues/3988#issuecomment-813936503


   Look like the bug is real. Why did you close your PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] ychdesign commented on issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
ychdesign commented on issue #3988:
URL: https://github.com/apache/apisix/issues/3988#issuecomment-820888124


   > 不知道为什么会将这几行代码去掉？
   > 
   > ```lua
   > local ok, err = red:set_keepalive(10000, 100)
   > if not ok then
   >     return nil, err
   > end
   > ```
   > 
   > @ychdesign
   
   sorry. I ignored it by mistake. would you make a pr to solve that？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu closed issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
Yiyiyimu closed issue #3988:
URL: https://github.com/apache/apisix/issues/3988


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] ychdesign commented on issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
ychdesign commented on issue #3988:
URL: https://github.com/apache/apisix/issues/3988#issuecomment-813937844


   pr check failed，在改pr的信息
   
   
   
   ------------------&nbsp;原始邮件&nbsp;------------------
   发件人: ***@***.***&gt;; 
   发送时间: 2021年4月6日(星期二) 下午4:31
   收件人: ***@***.***&gt;; 
   抄送: ***@***.***&gt;; ***@***.***&gt;; 
   主题: Re: [apache/apisix] bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios (#3988)
   
   
   
   
   
    
   Look like the bug is real. Why did you close your PR?
    
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] zwjzxh520 edited a comment on issue #3988: bug: limit-count may prevent more requests by mistake that should access normally in High concurrency scenarios

Posted by GitBox <gi...@apache.org>.
zwjzxh520 edited a comment on issue #3988:
URL: https://github.com/apache/apisix/issues/3988#issuecomment-820871643


   不知道为什么会将这几行代码去掉？
   
   ```lua
   local ok, err = red:set_keepalive(10000, 100)
   if not ok then
       return nil, err
   end
   ```
   
   @ychdesign 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org