You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2017/10/19 19:21:43 UTC

[GitHub] nifi-minifi-cpp pull request #150: MINIFI-372: Resolve issues with missed co...

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/150

    MINIFI-372: Resolve issues with missed commits

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-372-FIX

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #150
    
----
commit d83aa8cd1d6087d3f908de5dcd3f19a16ad40dc2
Author: Marc Parisi <ph...@apache.org>
Date:   2017-10-19T19:20:57Z

    MINIFI-372: Resolve issues with missed commits

----


---

[GitHub] nifi-minifi-cpp issue #150: MINIFI-372: Resolve issues with missed commits

Posted by minifirocks <gi...@git.apache.org>.

Github user minifirocks commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/150
  
    @phrocker please merge these two commits into one


---

[GitHub] nifi-minifi-cpp issue #150: MINIFI-372: Resolve issues with missed commits

Posted by minifirocks <gi...@git.apache.org>.

Github user minifirocks commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/150
  
    @phrocker looks good.


---

[GitHub] nifi-minifi-cpp pull request #150: MINIFI-372: Resolve issues with missed co...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/150


---