[GitHub] [superset] hughhhh commented on a diff in pull request #22853: chore(WIP): Refactor ExploreMixin to power both Datasets (SqlaTable) and Query models

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on code in PR #22853:
URL: https://github.com/apache/superset/pull/22853#discussion_r1113782733


##########
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.jsx:
##########
@@ -48,7 +48,7 @@ class AdhocMetricOption extends React.PureComponent {
   }
 
   onRemoveMetric(e) {
-    e.stopPropagation();
+    if (e !== undefined) e.stopPropagation();

Review Comment:
   using this as a defense statement some cases `e` would come back null



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org