[GitHub] [hadoop-ozone] fapifta commented on issue #781: HDDS-3353. Remove unnecessary transitive hadoop-common dependencies on server side.

[GitBox <gi...@apache.org>]

fapifta commented on issue #781: HDDS-3353. Remove unnecessary transitive hadoop-common dependencies on server side.
URL: https://github.com/apache/hadoop-ozone/pull/781#issuecomment-610495296
 
 
   Hi Marton, thank you for taking this on and looking into my suggestion deeper.
   
   I ran a search for the string curator in the code, and found one more thing. I have added a pull request against your fork with the fix, please review and commit it if you agree.
   
   The change to have a centralized dependency for the server and for the tests is a way I really like, and I am +1 on that part of the implementation.
   
   I have done a quick check where we use hadoop-common as a dependency, and how we manage it there, and the followings came up:
   - mini-chaos-tests, insight, integration-tests, tools, common, container-service, client: are list hadoop-common as a dependency, we may use the new tests dependency here
   - hadoop-ozone-fs, csi: pom mentions hadoop-common but as an exclusion this is fine
   This is on its way as a PR to your branch also, after a quick local build.
   
   On the other hand, I am unsure whether after these changes we need the hadoop-common dependency to be listed in the DependencyManagement section of the main pom.xml, as we use the hadoop.version property in the 3 remaining place in hadoop-dependency-server, in hadoop-dependency-test, and in hadoop-dependency-client and all modules now depends on these pseudo modules. My guess is we need it, but I am not that deeply familiar with dependency resolution to understand this easily so I thought to ask first. ;)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org