You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Willem Jiang <ni...@iona.com> on 2007/03/06 08:48:22 UTC
Re: [jira] Created: (CXF-446) Allow JAX-WS implementation bean not
to implement the service endpoint interface
Hi Jarek,
I am sorry I can't apply all you patch.
I found these two test failed in both Linux and Windows box after I
applied you patch.
ClientServerGreeterBaseNoWsdlTest
ClientServerGreeterNoWsdlTest
I looked these issue and tried to fix it. I caught the message
request and response between the client and server.
I found the request and response message's target namespace is not
matched, so the two tests failed.
Current CXF's code first approach is implemented by simple front end's
ReflectionServiceFactoryBean. It work for turning the POJO style Java
code to service model.
It does not consume the Jaxws annotation and take the response message
target namespace as the operation namespace
{http://cxf.apache.org/greeter_control}.
And the response message target namespace actually should be
{http://cxf.apache.org/greeter_control/types}.
To fix this issue, we need to implement creation of service module from
class which is annotated with the Jaxws annotation without WSDL location.
So I will fill a JIRA task for it, if there is no other objection.
Cheers,
Willem.
Jarek Gawor (JIRA) wrote:
>Allow JAX-WS implementation bean not to implement the service endpoint interface
>--------------------------------------------------------------------------------
>
> Key: CXF-446
> URL: https://issues.apache.org/jira/browse/CXF-446
> Project: CXF
> Issue Type: Bug
> Components: JAX-WS Runtime
> Reporter: Jarek Gawor
> Attachments: CXF-446.patch
>
>JAX-WS services (as per spec) are not required to implement the service endpoint interface. Right now, if the service does not implement the SEI, a "object is not an instance of" error is returned on an invocation. The attached patch enables the services not to implement the SEI and contains test for such cases.
>
>This patch also contains updated test cases for CXF-444.
>
>
>
>
>
Re: [jira] Created: (CXF-446) Allow JAX-WS implementation bean not to implement the service endpoint interface
Posted by Jarek Gawor <jg...@gmail.com>.
Thank you!
Btw, invocations on annotated service without the wsdlLocation
attribute used to work fine.
Thanks again,
Jarek
On 3/6/07, Willem Jiang <ni...@iona.com> wrote:
> Hi Jarek,
>
> I applied you patch and skipped the tests of
> ClientServiceGreeterBaseNoWsdlTest and ClientServiceGreeterNoWsdlTest.
> It is now in the reversion 515443.
>
> Cheers,
>
> Willem.
>
> Jarek Gawor wrote:
>
> > Willem,
> >
> > Right, these tests were expected to fail. I submitted them to
> > demonstrate the problem when no wsdlLocation is specified. However,
> > the patch (in CXF-446) also contains tests cases and a fix for the
> > issue where the service implementation bean does not implement the
> > SEI. Without that patch the ClientServiceGreeterBaseTest and
> > ClientServiceGreeterBaseNoWsdlTest would fail with "object is not an
> > instance" error. After applying the fix to JAX-WS code the
> > ClientServiceGreeterBaseTest should pass and
> > ClientServiceGreeterBaseNoWsdlTest fail with null reply (just like
> > ClientServiceGreeterNoWsdlTest). So maybe at least the passing test
> > cases (along with the JAX-WS fix) can be applied at this time.
> >
> > Thanks,
> > Jarek
> >
> > On 3/6/07, Willem Jiang <ni...@iona.com> wrote:
> >
> >> Hi Jarek,
> >>
> >> I am sorry I can't apply all you patch.
> >> I found these two test failed in both Linux and Windows box after I
> >> applied you patch.
> >> ClientServerGreeterBaseNoWsdlTest
> >> ClientServerGreeterNoWsdlTest
> >> I looked these issue and tried to fix it. I caught the message
> >> request and response between the client and server.
> >> I found the request and response message's target namespace is not
> >> matched, so the two tests failed.
> >>
> >> Current CXF's code first approach is implemented by simple front end's
> >> ReflectionServiceFactoryBean. It work for turning the POJO style Java
> >> code to service model.
> >> It does not consume the Jaxws annotation and take the response message
> >> target namespace as the operation namespace
> >> {http://cxf.apache.org/greeter_control}.
> >> And the response message target namespace actually should be
> >> {http://cxf.apache.org/greeter_control/types}.
> >>
> >> To fix this issue, we need to implement creation of service module from
> >> class which is annotated with the Jaxws annotation without WSDL
> >> location.
> >> So I will fill a JIRA task for it, if there is no other objection.
> >>
> >> Cheers,
> >>
> >> Willem.
> >>
> >> Jarek Gawor (JIRA) wrote:
> >>
> >> >Allow JAX-WS implementation bean not to implement the service
> >> endpoint interface
> >> >--------------------------------------------------------------------------------
> >>
> >> >
> >> > Key: CXF-446
> >> > URL: https://issues.apache.org/jira/browse/CXF-446
> >> > Project: CXF
> >> > Issue Type: Bug
> >> > Components: JAX-WS Runtime
> >> > Reporter: Jarek Gawor
> >> > Attachments: CXF-446.patch
> >> >
> >> >JAX-WS services (as per spec) are not required to implement the
> >> service endpoint interface. Right now, if the service does not
> >> implement the SEI, a "object is not an instance of" error is returned
> >> on an invocation. The attached patch enables the services not to
> >> implement the SEI and contains test for such cases.
> >> >
> >> >This patch also contains updated test cases for CXF-444.
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
> >>
> >
>
>
Re: [jira] Created: (CXF-446) Allow JAX-WS implementation bean not
to implement the service endpoint interface
Posted by Willem Jiang <ni...@iona.com>.
Hi Jarek,
I applied you patch and skipped the tests of
ClientServiceGreeterBaseNoWsdlTest and ClientServiceGreeterNoWsdlTest.
It is now in the reversion 515443.
Cheers,
Willem.
Jarek Gawor wrote:
> Willem,
>
> Right, these tests were expected to fail. I submitted them to
> demonstrate the problem when no wsdlLocation is specified. However,
> the patch (in CXF-446) also contains tests cases and a fix for the
> issue where the service implementation bean does not implement the
> SEI. Without that patch the ClientServiceGreeterBaseTest and
> ClientServiceGreeterBaseNoWsdlTest would fail with "object is not an
> instance" error. After applying the fix to JAX-WS code the
> ClientServiceGreeterBaseTest should pass and
> ClientServiceGreeterBaseNoWsdlTest fail with null reply (just like
> ClientServiceGreeterNoWsdlTest). So maybe at least the passing test
> cases (along with the JAX-WS fix) can be applied at this time.
>
> Thanks,
> Jarek
>
> On 3/6/07, Willem Jiang <ni...@iona.com> wrote:
>
>> Hi Jarek,
>>
>> I am sorry I can't apply all you patch.
>> I found these two test failed in both Linux and Windows box after I
>> applied you patch.
>> ClientServerGreeterBaseNoWsdlTest
>> ClientServerGreeterNoWsdlTest
>> I looked these issue and tried to fix it. I caught the message
>> request and response between the client and server.
>> I found the request and response message's target namespace is not
>> matched, so the two tests failed.
>>
>> Current CXF's code first approach is implemented by simple front end's
>> ReflectionServiceFactoryBean. It work for turning the POJO style Java
>> code to service model.
>> It does not consume the Jaxws annotation and take the response message
>> target namespace as the operation namespace
>> {http://cxf.apache.org/greeter_control}.
>> And the response message target namespace actually should be
>> {http://cxf.apache.org/greeter_control/types}.
>>
>> To fix this issue, we need to implement creation of service module from
>> class which is annotated with the Jaxws annotation without WSDL
>> location.
>> So I will fill a JIRA task for it, if there is no other objection.
>>
>> Cheers,
>>
>> Willem.
>>
>> Jarek Gawor (JIRA) wrote:
>>
>> >Allow JAX-WS implementation bean not to implement the service
>> endpoint interface
>> >--------------------------------------------------------------------------------
>>
>> >
>> > Key: CXF-446
>> > URL: https://issues.apache.org/jira/browse/CXF-446
>> > Project: CXF
>> > Issue Type: Bug
>> > Components: JAX-WS Runtime
>> > Reporter: Jarek Gawor
>> > Attachments: CXF-446.patch
>> >
>> >JAX-WS services (as per spec) are not required to implement the
>> service endpoint interface. Right now, if the service does not
>> implement the SEI, a "object is not an instance of" error is returned
>> on an invocation. The attached patch enables the services not to
>> implement the SEI and contains test for such cases.
>> >
>> >This patch also contains updated test cases for CXF-444.
>> >
>> >
>> >
>> >
>> >
>>
>>
>
Re: [jira] Created: (CXF-446) Allow JAX-WS implementation bean not to implement the service endpoint interface
Posted by Jarek Gawor <jg...@gmail.com>.
Willem,
Right, these tests were expected to fail. I submitted them to
demonstrate the problem when no wsdlLocation is specified. However,
the patch (in CXF-446) also contains tests cases and a fix for the
issue where the service implementation bean does not implement the
SEI. Without that patch the ClientServiceGreeterBaseTest and
ClientServiceGreeterBaseNoWsdlTest would fail with "object is not an
instance" error. After applying the fix to JAX-WS code the
ClientServiceGreeterBaseTest should pass and
ClientServiceGreeterBaseNoWsdlTest fail with null reply (just like
ClientServiceGreeterNoWsdlTest). So maybe at least the passing test
cases (along with the JAX-WS fix) can be applied at this time.
Thanks,
Jarek
On 3/6/07, Willem Jiang <ni...@iona.com> wrote:
> Hi Jarek,
>
> I am sorry I can't apply all you patch.
> I found these two test failed in both Linux and Windows box after I
> applied you patch.
> ClientServerGreeterBaseNoWsdlTest
> ClientServerGreeterNoWsdlTest
> I looked these issue and tried to fix it. I caught the message
> request and response between the client and server.
> I found the request and response message's target namespace is not
> matched, so the two tests failed.
>
> Current CXF's code first approach is implemented by simple front end's
> ReflectionServiceFactoryBean. It work for turning the POJO style Java
> code to service model.
> It does not consume the Jaxws annotation and take the response message
> target namespace as the operation namespace
> {http://cxf.apache.org/greeter_control}.
> And the response message target namespace actually should be
> {http://cxf.apache.org/greeter_control/types}.
>
> To fix this issue, we need to implement creation of service module from
> class which is annotated with the Jaxws annotation without WSDL location.
> So I will fill a JIRA task for it, if there is no other objection.
>
> Cheers,
>
> Willem.
>
> Jarek Gawor (JIRA) wrote:
>
> >Allow JAX-WS implementation bean not to implement the service endpoint interface
> >--------------------------------------------------------------------------------
> >
> > Key: CXF-446
> > URL: https://issues.apache.org/jira/browse/CXF-446
> > Project: CXF
> > Issue Type: Bug
> > Components: JAX-WS Runtime
> > Reporter: Jarek Gawor
> > Attachments: CXF-446.patch
> >
> >JAX-WS services (as per spec) are not required to implement the service endpoint interface. Right now, if the service does not implement the SEI, a "object is not an instance of" error is returned on an invocation. The attached patch enables the services not to implement the SEI and contains test for such cases.
> >
> >This patch also contains updated test cases for CXF-444.
> >
> >
> >
> >
> >
>
>