You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2020/11/25 22:00:31 UTC
[incubator-superset] 01/01: chore: Fix TableModelView super call
This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a commit to branch john-bodley--fix-tablemodelview-edit-super
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit 5072b24398335af84d2e2e2d0058234cf972c7b2
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Thu Nov 26 10:59:55 2020 +1300
chore: Fix TableModelView super call
---
superset/connectors/sqla/views.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py
index 3533fc5..23efa86 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -481,9 +481,9 @@ class TableModelView( # pylint: disable=too-many-ancestors
@expose("/edit/<pk>", methods=["GET", "POST"])
@has_access
- def edit(self, pk: int) -> FlaskResponse:
+ def edit(self, pk: str) -> FlaskResponse:
"""Simple hack to redirect to explore view after saving"""
- resp = super(TableModelView, self).edit(pk)
+ resp = super().edit(pk)
if isinstance(resp, str):
return resp
return redirect("/superset/explore/table/{}/".format(pk))