You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "spuru9 (via GitHub)" <gi...@apache.org> on 2026/05/02 06:40:39 UTC
[PR] [hotfix][runtime-web] Bring *-logs components under eslint enforcement [flink]
spuru9 opened a new pull request, #28086:
URL: https://github.com/apache/flink/pull/28086
## What is the purpose of the change
`.eslintignore` has a bare `logs` pattern that uses gitignore
semantics — it matches a directory of that name at any depth. It was
meant for a top-level log-output directory but also captures
`src/app/pages/{job-manager,task-manager}/logs/`, the source dirs
holding the dashboard's log pages. Files under those paths were
silently skipped by `lint-staged`, CI, and IDE eslint, so style drift
accumulated and eventually leaked into a feature PR (#27774) as
unrelated reformat noise.
## Brief change log
- Anchor the pattern at the project root: `logs` -> `/logs`.
- Run `eslint --fix` on both `*-logs.component.ts` files (prettier
whitespace/quotes/brackets, `import/order`, import deduplication).
- Add `: void` return types to `ngOnInit` and `reload` in both
components (`@typescript-eslint/explicit-function-return-type` is
not auto-fixable).
## Verifying this change
cd flink-runtime-web/web-dashboard
rm -f .eslintcache
npm run lint # exits 0; both files are now included by eslint
## Does this pull request potentially affect one of the following parts
- Dependencies: no
- Public API: no
- Serializers: no
- Runtime per-record code paths: no
- Deployment/recovery (JobManager, Checkpointing, K8s/Yarn, ZooKeeper): no
- S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
## Was the change made with AI assistance?
- [x] Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring logs components under eslint enforcement [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #28086:
URL: https://github.com/apache/flink/pull/28086#discussion_r3177068958
##########
flink-runtime-web/web-dashboard/.eslintignore:
##########
@@ -5,7 +5,7 @@ tsc-out
dist
Review Comment:
Done in 6b0b1601ebf — anchored both `tsc-out` and `dist` to the project root. Left `gen` and `web` alone since the suggestion was scoped to the three top-level artifact dirs (`logs`, `tsc-out`, `dist`) and `web` in particular is the build-output dir consumed by flink-runtime, so I'd rather not narrow it without more thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring *-logs components under eslint enforcement [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #28086:
URL: https://github.com/apache/flink/pull/28086#issuecomment-4363263566
@featzhang Can you review this hotfix. Related to the one I referred to, have made the fix so it don't come up in future PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring logs components under eslint enforcement [flink]
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on code in PR #28086:
URL: https://github.com/apache/flink/pull/28086#discussion_r3177018072
##########
flink-runtime-web/web-dashboard/.eslintignore:
##########
@@ -5,7 +5,7 @@ tsc-out
dist
Review Comment:
Same bare-pattern footgun applies to `dist` here and `tsc-out` on the line above — they will also match any nested directory of that name. No source dirs collide today, but anchoring them (`/dist`, `/tsc-out`) in the same commit would close the loophole for good and keep the three top-level artifact dirs consistent. Non-blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring logs components under eslint enforcement [flink]
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on code in PR #28086:
URL: https://github.com/apache/flink/pull/28086#discussion_r3177020836
##########
flink-runtime-web/web-dashboard/.eslintignore:
##########
@@ -5,7 +5,7 @@ tsc-out
dist
Review Comment:
FWIW, I bumped into the same issue while working on #27774 — the lint-skipped `*-logs.component.ts` files ended up dragging unrelated reformat noise into that PR, and I ended up reverting the noise there. I noticed the underlying `.eslintignore` problem at the time but didn't touch it since it was off-topic for that change. Glad to see it getting a proper fix here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring *-logs components under eslint enforcement [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28086:
URL: https://github.com/apache/flink/pull/28086#issuecomment-4363204381
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "569255d1a89fe543cfdf8e91a241d37ca84610c3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "569255d1a89fe543cfdf8e91a241d37ca84610c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 569255d1a89fe543cfdf8e91a241d37ca84610c3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring logs components under eslint enforcement [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #28086:
URL: https://github.com/apache/flink/pull/28086#issuecomment-4364557025
@featzhang Have addressed the comment. Can you review/approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring logs components under eslint enforcement [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on code in PR #28086:
URL: https://github.com/apache/flink/pull/28086#discussion_r3177070366
##########
flink-runtime-web/web-dashboard/.eslintignore:
##########
@@ -5,7 +5,7 @@ tsc-out
dist
Review Comment:
@featzhang Made the change. Can you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring logs components under eslint enforcement [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #28086:
URL: https://github.com/apache/flink/pull/28086#issuecomment-4449061475
cc @ferenc-csaky @davidradl @snuyanzin for binding approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][runtime-web] Bring logs components under eslint enforcement [flink]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky merged PR #28086:
URL: https://github.com/apache/flink/pull/28086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org