You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/22 04:32:46 UTC
[GitHub] [spark] sarutak opened a new pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
sarutak opened a new pull request #32285:
URL: https://github.com/apache/spark/pull/32285
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes a change that allows us to build SparkR with SBT.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In the current master, SparkR can be built only with Maven.
It's helpful if we can built it with SBT.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
I confirmed that I can build SparkR on Ubuntu 20.04 with the following command.
```
build/sbt -Psparkr package
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824536743
cc @srowen and @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824566817
**[Test build #137778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137778/testReport)** for PR 32285 at commit [`445050b`](https://github.com/apache/spark/commit/445050b4b309a1b39a0d24e553fa555a5ed1b6fe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824792371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #32285:
URL: https://github.com/apache/spark/pull/32285#discussion_r618116679
##########
File path: project/SparkBuild.scala
##########
@@ -888,6 +892,22 @@ object PySparkAssembly {
}
+object SparkR {
+ import scala.sys.process.Process
+
+ val buildRPackage = taskKey[Unit]("Build the R package")
+ lazy val settings = Seq(
+ buildRPackage := {
+ val command = baseDirectory.value / ".." / "R" / "install-dev.sh"
+ Process(command.toString).!!
+ },
+ (Compile / compile) := {
+ buildRPackage.value
Review comment:
Thanks. I've updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824792430
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42333/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32285:
URL: https://github.com/apache/spark/pull/32285#discussion_r618096280
##########
File path: R/README.md
##########
@@ -17,10 +17,14 @@ export R_HOME=/home/username/R
#### Build Spark
-Build Spark with [Maven](https://spark.apache.org/docs/latest/building-spark.html#buildmvn) and include the `-Psparkr` profile to build the R package. For example to use the default Hadoop versions you can run
+Build Spark with [Maven](https://spark.apache.org/docs/latest/building-spark.html#buildmvn) or [SBT](http://spark.apache.org/docs/latest/building-spark.html#building-with-sbt), and include the `-Psparkr` profile to build the R package. For example to use the default Hadoop versions you can run
Review comment:
Oh, `http` -> `https`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824565956
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824542276
**[Test build #137771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137771/testReport)** for PR 32285 at commit [`77a8d45`](https://github.com/apache/spark/commit/77a8d4541ac9a2efef093ba9bba093354ee49ff5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824566817
**[Test build #137778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137778/testReport)** for PR 32285 at commit [`445050b`](https://github.com/apache/spark/commit/445050b4b309a1b39a0d24e553fa555a5ed1b6fe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824573098
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42305/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824598497
**[Test build #137788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137788/testReport)** for PR 32285 at commit [`1f9d827`](https://github.com/apache/spark/commit/1f9d827800e860afe0b0e01b2d8736dc7ca1af68).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824755892
**[Test build #137804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137804/testReport)** for PR 32285 at commit [`1f9d827`](https://github.com/apache/spark/commit/1f9d827800e860afe0b0e01b2d8736dc7ca1af68).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824685844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824755892
**[Test build #137804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137804/testReport)** for PR 32285 at commit [`1f9d827`](https://github.com/apache/spark/commit/1f9d827800e860afe0b0e01b2d8736dc7ca1af68).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824675485
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824605306
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42307/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824645215
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137771/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824542767
Got it!
> mvn -Psparkr runs R/install-dev.sh automatically but SBT didn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824573098
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42305/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824926199
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137804/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32285:
URL: https://github.com/apache/spark/pull/32285#discussion_r618097706
##########
File path: project/SparkBuild.scala
##########
@@ -888,6 +892,22 @@ object PySparkAssembly {
}
+object SparkR {
+ import scala.sys.process.Process
+
+ val buildRPackage = taskKey[Unit]("Build the R package")
+ lazy val settings = Seq(
+ buildRPackage := {
+ val command = baseDirectory.value / ".." / "R" / "install-dev.sh"
+ Process(command.toString).!!
+ },
+ (Compile / compile) := {
+ buildRPackage.value
Review comment:
I think we build SparkR after the compilation of core so the order should probably be switched with the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824685886
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42317/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824598497
**[Test build #137788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137788/testReport)** for PR 32285 at commit [`1f9d827`](https://github.com/apache/spark/commit/1f9d827800e860afe0b0e01b2d8736dc7ca1af68).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824541998
> It's great. Could you add the build command into R/README.md along with the existing mvn command, @sarutak ?
O.K, I'll do it.
> BTW, I can do the AS-IS master branch, what is the missing before this PR?
`mvn -Psparkr` runs `R/install-dev.sh` automatically but SBT didn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824675485
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824926199
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137804/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824746736
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137788/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824542276
**[Test build #137771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137771/testReport)** for PR 32285 at commit [`77a8d45`](https://github.com/apache/spark/commit/77a8d4541ac9a2efef093ba9bba093354ee49ff5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824792430
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42333/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824605306
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42307/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824540353
BTW, I can do the AS-IS master branch, what is the missing before this PR?
```
$ build/sbt package -Psparkr
$ R/install-dev.sh
$ bin/sparkR
R version 3.5.2 (2018-12-20) -- "Eggshell Igloo"
Copyright (C) 2018 The R Foundation for Statistical Computing
Platform: x86_64-apple-darwin15.6.0 (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
Natural language support but running in an English locale
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
Launching java with spark-submit command /Users/dongjoon/APACHE/spark-merge/bin/spark-submit "sparkr-shell" /var/folders/p5/tzyffbvj0md4djphs4fym9zw0000gn/T//RtmpV1x8wW/backend_portc786d577092
Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
21/04/21 22:02:46 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
21/04/21 22:02:47 WARN SQLUtils: SparkR: enableHiveSupport is requested for SparkSession but Spark is not built with Hive or spark.sql.catalogImplementation is not set to 'hive', falling back to without Hive support.
Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
/___/ .__/\_,_/_/ /_/\_\ version 3.2.0-SNAPSHOT
/_/
SparkSession Web UI available at http://localhost:4040
SparkSession available as 'spark'(master = local[*], app id = local-1619067767184).
>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824605259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824563411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824642818
**[Test build #137771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137771/testReport)** for PR 32285 at commit [`77a8d45`](https://github.com/apache/spark/commit/77a8d4541ac9a2efef093ba9bba093354ee49ff5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824685886
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42317/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824753780
retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824673128
**[Test build #137778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137778/testReport)** for PR 32285 at commit [`445050b`](https://github.com/apache/spark/commit/445050b4b309a1b39a0d24e553fa555a5ed1b6fe).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824761288
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824573082
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42305/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824727265
**[Test build #137788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137788/testReport)** for PR 32285 at commit [`1f9d827`](https://github.com/apache/spark/commit/1f9d827800e860afe0b0e01b2d8736dc7ca1af68).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824891564
**[Test build #137804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137804/testReport)** for PR 32285 at commit [`1f9d827`](https://github.com/apache/spark/commit/1f9d827800e860afe0b0e01b2d8736dc7ca1af68).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824645215
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137771/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #32285:
URL: https://github.com/apache/spark/pull/32285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824746736
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137788/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #32285:
URL: https://github.com/apache/spark/pull/32285#discussion_r618096798
##########
File path: R/README.md
##########
@@ -17,10 +17,14 @@ export R_HOME=/home/username/R
#### Build Spark
-Build Spark with [Maven](https://spark.apache.org/docs/latest/building-spark.html#buildmvn) and include the `-Psparkr` profile to build the R package. For example to use the default Hadoop versions you can run
+Build Spark with [Maven](https://spark.apache.org/docs/latest/building-spark.html#buildmvn) or [SBT](http://spark.apache.org/docs/latest/building-spark.html#building-with-sbt), and include the `-Psparkr` profile to build the R package. For example to use the default Hadoop versions you can run
Review comment:
Ah, I just copied from the URL bar. I'll change it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32285: [SPARK-35180][BUILD] Allow to build SparkR with SBT
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32285:
URL: https://github.com/apache/spark/pull/32285#issuecomment-824565956
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org