You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/02 03:00:46 UTC

[GitHub] [dubbo] guohao opened a new issue #8659: [3.0-Triple] TripleRpcException should be removed and support dubbo status to triple status mapping

guohao opened a new issue #8659:
URL: https://github.com/apache/dubbo/issues/8659


   - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
   - [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
   
   Dubbo's `RpcException` contains a `code` field and it is enough for exceptions occured in invocation chain. Therefore is no need to add complexity for user coding and framework processing.
   
   What we need to do:
   1.  Replace `TripleRpcException` with `RpcException`
   2. Add dubbo code to grpc status mapping in `org.apache.dubbo.rpc.protocol.tri.GrpcStatus`
   3. Add UT for above modifications.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] guohao closed issue #8659: [3.0-Triple] TripleRpcException should be removed and support dubbo status to triple status mapping

Posted by GitBox <gi...@apache.org>.
guohao closed issue #8659:
URL: https://github.com/apache/dubbo/issues/8659


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] dockerXieShouYu commented on issue #8659: [3.0-Triple] TripleRpcException should be removed and support dubbo status to triple status mapping

Posted by GitBox <gi...@apache.org>.
dockerXieShouYu commented on issue #8659:
URL: https://github.com/apache/dubbo/issues/8659#issuecomment-911109018


   > * [x]  I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
   > * [x]  I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
   > 
   > Dubbo's `RpcException` contains a `code` field and it is enough for exceptions occured in invocation chain. Therefore is no need to add complexity for user coding and framework processing.
   > 
   > What we need to do:
   > 
   > 1. Replace `TripleRpcException` with `RpcException`
   > 2. Add dubbo code to grpc status mapping in `org.apache.dubbo.rpc.protocol.tri.GrpcStatus`
   > 3. Add UT for above modifications.
   
   I will finish this task


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org