You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/12 15:32:22 UTC

[GitHub] [ignite] Vladsz83 commented on a change in pull request #8447: IGNITE-13694 Check difference between SIGTERM, SIGKILL and Disconnect…

Vladsz83 commented on a change in pull request #8447:
URL: https://github.com/apache/ignite/pull/8447#discussion_r522196062



##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
##########
@@ -200,16 +200,19 @@ def __exec_on_node(node, task, start_waiter=None, delay_ms=0, time_holder=None):
 
         task(node)
 
-    def disconnect(self, nodes=None):
+    def drop_network(self, nodes=None):
         """
         Disconnects node from cluster.
         """
-        self.logger.info("Disconnecting the node.")
+        self.logger.info("Disconnecting the node(s)...")
 
         if nodes is None:
             assert self.num_nodes == 1
             nodes = self.nodes
 
+        for node in nodes:
+            self.logger.debug("Disconnecting " + node.account.hostname + ".")

Review comment:
       I suppose we would need this at info level. Next code provides on debug "Activating netfilter on...". This also says which node ig going to get stopped. But with extented netfilter info.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org