You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2015/05/22 14:50:42 UTC
Review Request 34594: Ranger database check: Misc UI tweaks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34594/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
Bugs: AMBARI-11337
https://issues.apache.org/jira/browse/AMBARI-11337
Repository: ambari
Description
-------
Following issues needs to be resolved as part of this ticket:
On Select services page after selecting ranger and proceeding: Ambari web should not have specific references to HDP or any other stack name. Remove reference to HDP 2.2. Instead refer to Ranger 0.4.0 or show that specific requirement only if Ranger 0.4.0 is being installed (again logic depending on Ranger service version rather than HDP version).
While landing on Customize services page JDBC driver warning is not shown until the database option is changed. Expected behavior is to show the warning when user lands on the page irrespective of the DB option value.
On switching to Ranger service on customize services page, undo buttons are shown by default for Driver class name for a JDBC Ranger database and Ranger DB host . Clicking on undo button for Driver class name for a JDBC Ranger database makes it blank. Expected behavior is that no undo sign should be present for this property. It's behavior should be similar to JDBC connect string for a Ranger database.
Default value for Ranger DB host should be blank in stack meaning user should be enforced to enter a value on customize service page.
User friendly name should be used for DB FLAVOR and it's options
DB FLAVOR -> DB Flavor
MYSQL -> Existing MySQL Database
ORACLE -> Existing Oracle Database
POSTGRES -> Existing PostgreSQL Database
MSSQL -> Existing Microsoft SQL Database
Show SQL Command Invoker on user interface only if it makes sense and user is likely to tweak it. Otherwise depending upon the ranger JDBC driver class, SQL command invoker can be derived on agent script and no need to expose it in ambari API and UI.
The order of properties shown in DB settings section needs to corrected. In my opinion "Ranger Server host, DB Flavor, Ranger DB host, Ranger DB username, Ranger DB password, Ranger DB root user, Ranger DB root password, Ranger DB name, Driver class name for a JDBC Ranger database, JDBC connect string for a Ranger database, Test Connection, Ranger Audit DB name, Ranger Audit DB username, Ranger Audit DB password.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml 52ce1bf
ambari-web/app/data/HDP2.2/site_properties.js 537fa84
ambari-web/app/data/HDP2.3/site_properties.js 5a351b5
ambari-web/app/messages.js 15e275a
ambari-web/app/views/common/controls_view.js 995ace7
Diff: https://reviews.apache.org/r/34594/diff/
Testing
-------
6150 tests complete (11 seconds)
86 tests pending
Thanks,
Aleksandr Kovalenko
Re: Review Request 34594: Ranger database check: Misc UI tweaks
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34594/#review85339
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On May 26, 2015, 2:39 p.m., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34594/
> -----------------------------------------------------------
>
> (Updated May 26, 2015, 2:39 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-11337
> https://issues.apache.org/jira/browse/AMBARI-11337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Following issues needs to be resolved as part of this ticket:
> On Select services page after selecting ranger and proceeding: Ambari web should not have specific references to HDP or any other stack name. Remove reference to HDP 2.2. Instead refer to Ranger 0.4.0 or show that specific requirement only if Ranger 0.4.0 is being installed (again logic depending on Ranger service version rather than HDP version).
> While landing on Customize services page JDBC driver warning is not shown until the database option is changed. Expected behavior is to show the warning when user lands on the page irrespective of the DB option value.
> On switching to Ranger service on customize services page, undo buttons are shown by default for Driver class name for a JDBC Ranger database and Ranger DB host . Clicking on undo button for Driver class name for a JDBC Ranger database makes it blank. Expected behavior is that no undo sign should be present for this property. It's behavior should be similar to JDBC connect string for a Ranger database.
> Default value for Ranger DB host should be blank in stack meaning user should be enforced to enter a value on customize service page.
> User friendly name should be used for DB FLAVOR and it's options
> DB FLAVOR -> DB Flavor
> MYSQL -> Existing MySQL Database
> ORACLE -> Existing Oracle Database
> POSTGRES -> Existing PostgreSQL Database
> MSSQL -> Existing Microsoft SQL Database
> Show SQL Command Invoker on user interface only if it makes sense and user is likely to tweak it. Otherwise depending upon the ranger JDBC driver class, SQL command invoker can be derived on agent script and no need to expose it in ambari API and UI.
> The order of properties shown in DB settings section needs to corrected. In my opinion "Ranger Server host, DB Flavor, Ranger DB host, Ranger DB username, Ranger DB password, Ranger DB root user, Ranger DB root password, Ranger DB name, Driver class name for a JDBC Ranger database, JDBC connect string for a Ranger database, Test Connection, Ranger Audit DB name, Ranger Audit DB username, Ranger Audit DB password.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml e47a251
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py be01370
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml 52ce1bf
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 47d2b5a
> ambari-web/app/controllers/main/service/info/configs.js 5e49ae8
> ambari-web/app/data/HDP2.2/site_properties.js 537fa84
> ambari-web/app/data/HDP2.3/site_properties.js 19cf9b8
> ambari-web/app/messages.js 1ca9756
> ambari-web/app/views/common/controls_view.js 995ace7
>
> Diff: https://reviews.apache.org/r/34594/diff/
>
>
> Testing
> -------
>
> 6150 tests complete (11 seconds)
> 86 tests pending
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>
Re: Review Request 34594: Ranger database check: Misc UI tweaks
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34594/
-----------------------------------------------------------
(Updated Травень 26, 2015, 2:39 після полудня)
Review request for Ambari, Andriy Babiichuk, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
Changes
-------
updated patch with BE changes and new FE changes
Bugs: AMBARI-11337
https://issues.apache.org/jira/browse/AMBARI-11337
Repository: ambari
Description
-------
Following issues needs to be resolved as part of this ticket:
On Select services page after selecting ranger and proceeding: Ambari web should not have specific references to HDP or any other stack name. Remove reference to HDP 2.2. Instead refer to Ranger 0.4.0 or show that specific requirement only if Ranger 0.4.0 is being installed (again logic depending on Ranger service version rather than HDP version).
While landing on Customize services page JDBC driver warning is not shown until the database option is changed. Expected behavior is to show the warning when user lands on the page irrespective of the DB option value.
On switching to Ranger service on customize services page, undo buttons are shown by default for Driver class name for a JDBC Ranger database and Ranger DB host . Clicking on undo button for Driver class name for a JDBC Ranger database makes it blank. Expected behavior is that no undo sign should be present for this property. It's behavior should be similar to JDBC connect string for a Ranger database.
Default value for Ranger DB host should be blank in stack meaning user should be enforced to enter a value on customize service page.
User friendly name should be used for DB FLAVOR and it's options
DB FLAVOR -> DB Flavor
MYSQL -> Existing MySQL Database
ORACLE -> Existing Oracle Database
POSTGRES -> Existing PostgreSQL Database
MSSQL -> Existing Microsoft SQL Database
Show SQL Command Invoker on user interface only if it makes sense and user is likely to tweak it. Otherwise depending upon the ranger JDBC driver class, SQL command invoker can be derived on agent script and no need to expose it in ambari API and UI.
The order of properties shown in DB settings section needs to corrected. In my opinion "Ranger Server host, DB Flavor, Ranger DB host, Ranger DB username, Ranger DB password, Ranger DB root user, Ranger DB root password, Ranger DB name, Driver class name for a JDBC Ranger database, JDBC connect string for a Ranger database, Test Connection, Ranger Audit DB name, Ranger Audit DB username, Ranger Audit DB password.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml e47a251
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py be01370
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml 52ce1bf
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 47d2b5a
ambari-web/app/controllers/main/service/info/configs.js 5e49ae8
ambari-web/app/data/HDP2.2/site_properties.js 537fa84
ambari-web/app/data/HDP2.3/site_properties.js 19cf9b8
ambari-web/app/messages.js 1ca9756
ambari-web/app/views/common/controls_view.js 995ace7
Diff: https://reviews.apache.org/r/34594/diff/
Testing
-------
6150 tests complete (11 seconds)
86 tests pending
Thanks,
Aleksandr Kovalenko
Re: Review Request 34594: Ranger database check: Misc UI tweaks
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34594/
-----------------------------------------------------------
(Updated Травень 25, 2015, 12:07 після полудня)
Review request for Ambari, Andriy Babiichuk, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
Changes
-------
uploaded new patch
Bugs: AMBARI-11337
https://issues.apache.org/jira/browse/AMBARI-11337
Repository: ambari
Description
-------
Following issues needs to be resolved as part of this ticket:
On Select services page after selecting ranger and proceeding: Ambari web should not have specific references to HDP or any other stack name. Remove reference to HDP 2.2. Instead refer to Ranger 0.4.0 or show that specific requirement only if Ranger 0.4.0 is being installed (again logic depending on Ranger service version rather than HDP version).
While landing on Customize services page JDBC driver warning is not shown until the database option is changed. Expected behavior is to show the warning when user lands on the page irrespective of the DB option value.
On switching to Ranger service on customize services page, undo buttons are shown by default for Driver class name for a JDBC Ranger database and Ranger DB host . Clicking on undo button for Driver class name for a JDBC Ranger database makes it blank. Expected behavior is that no undo sign should be present for this property. It's behavior should be similar to JDBC connect string for a Ranger database.
Default value for Ranger DB host should be blank in stack meaning user should be enforced to enter a value on customize service page.
User friendly name should be used for DB FLAVOR and it's options
DB FLAVOR -> DB Flavor
MYSQL -> Existing MySQL Database
ORACLE -> Existing Oracle Database
POSTGRES -> Existing PostgreSQL Database
MSSQL -> Existing Microsoft SQL Database
Show SQL Command Invoker on user interface only if it makes sense and user is likely to tweak it. Otherwise depending upon the ranger JDBC driver class, SQL command invoker can be derived on agent script and no need to expose it in ambari API and UI.
The order of properties shown in DB settings section needs to corrected. In my opinion "Ranger Server host, DB Flavor, Ranger DB host, Ranger DB username, Ranger DB password, Ranger DB root user, Ranger DB root password, Ranger DB name, Driver class name for a JDBC Ranger database, JDBC connect string for a Ranger database, Test Connection, Ranger Audit DB name, Ranger Audit DB username, Ranger Audit DB password.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml 52ce1bf
ambari-web/app/data/HDP2.2/site_properties.js 537fa84
ambari-web/app/data/HDP2.3/site_properties.js 19cf9b8
ambari-web/app/messages.js d49169d
ambari-web/app/views/common/controls_view.js 995ace7
Diff: https://reviews.apache.org/r/34594/diff/
Testing
-------
6150 tests complete (11 seconds)
86 tests pending
Thanks,
Aleksandr Kovalenko
Re: Review Request 34594: Ranger database check: Misc UI tweaks
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34594/#review85063
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml
<https://reviews.apache.org/r/34594/#comment136529>
UI is still taking the default hostname.
ambari-web/app/data/HDP2.3/site_properties.js
<https://reviews.apache.org/r/34594/#comment136530>
This should come from ranger-admin-site.xml, and the property name is "ranger.jpa.jdbc.url"
This is the field that should be autopopulated when user changes host/flavor/dbname etc.
This should be passed down to agent in configurations->ranger-admin-site
ambari-web/app/data/HDP2.3/site_properties.js
<https://reviews.apache.org/r/34594/#comment136531>
Same like ranger_jdbc_connection_url, this should also be :
ranger.jpa.jdbc.driver coming from ranger-admin-site.xml
ambari-web/app/views/common/controls_view.js
<https://reviews.apache.org/r/34594/#comment136532>
Auto-population of DB properties is not working.
- Gautam Borad
On May 22, 2015, 12:50 p.m., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34594/
> -----------------------------------------------------------
>
> (Updated May 22, 2015, 12:50 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-11337
> https://issues.apache.org/jira/browse/AMBARI-11337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Following issues needs to be resolved as part of this ticket:
> On Select services page after selecting ranger and proceeding: Ambari web should not have specific references to HDP or any other stack name. Remove reference to HDP 2.2. Instead refer to Ranger 0.4.0 or show that specific requirement only if Ranger 0.4.0 is being installed (again logic depending on Ranger service version rather than HDP version).
> While landing on Customize services page JDBC driver warning is not shown until the database option is changed. Expected behavior is to show the warning when user lands on the page irrespective of the DB option value.
> On switching to Ranger service on customize services page, undo buttons are shown by default for Driver class name for a JDBC Ranger database and Ranger DB host . Clicking on undo button for Driver class name for a JDBC Ranger database makes it blank. Expected behavior is that no undo sign should be present for this property. It's behavior should be similar to JDBC connect string for a Ranger database.
> Default value for Ranger DB host should be blank in stack meaning user should be enforced to enter a value on customize service page.
> User friendly name should be used for DB FLAVOR and it's options
> DB FLAVOR -> DB Flavor
> MYSQL -> Existing MySQL Database
> ORACLE -> Existing Oracle Database
> POSTGRES -> Existing PostgreSQL Database
> MSSQL -> Existing Microsoft SQL Database
> Show SQL Command Invoker on user interface only if it makes sense and user is likely to tweak it. Otherwise depending upon the ranger JDBC driver class, SQL command invoker can be derived on agent script and no need to expose it in ambari API and UI.
> The order of properties shown in DB settings section needs to corrected. In my opinion "Ranger Server host, DB Flavor, Ranger DB host, Ranger DB username, Ranger DB password, Ranger DB root user, Ranger DB root password, Ranger DB name, Driver class name for a JDBC Ranger database, JDBC connect string for a Ranger database, Test Connection, Ranger Audit DB name, Ranger Audit DB username, Ranger Audit DB password.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml 52ce1bf
> ambari-web/app/data/HDP2.2/site_properties.js 537fa84
> ambari-web/app/data/HDP2.3/site_properties.js 5a351b5
> ambari-web/app/messages.js 15e275a
> ambari-web/app/views/common/controls_view.js 995ace7
>
> Diff: https://reviews.apache.org/r/34594/diff/
>
>
> Testing
> -------
>
> 6150 tests complete (11 seconds)
> 86 tests pending
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>