You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/17 02:22:39 UTC
[GitHub] [spark] yoda-mon opened a new pull request #34027: [SPARK-36778] Support ILIKE API on Scala(dataframe)
yoda-mon opened a new pull request #34027:
URL: https://github.com/apache/spark/pull/34027
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Support ILIKE (case insensitive LIKE) API on Scala.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
ILIKE statement on SQL interface is supported by SPARK-36674.
This PR will support Scala(dataframe) API for it.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Users can call `ilike` from dataframe.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921643918
**[Test build #143408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143408/testReport)** for PR 34027 at commit [`b26ae27`](https://github.com/apache/spark/commit/b26ae2772400de4286191d93daddb547c41266e2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921414115
**[Test build #143383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143383/testReport)** for PR 34027 at commit [`f7019ca`](https://github.com/apache/spark/commit/f7019caaa2d52e051949c2b937e363b5e981717b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921685906
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921433541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921544033
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47900/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34027:
URL: https://github.com/apache/spark/pull/34027#discussion_r710728304
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -846,6 +846,17 @@ class Column(val expr: Expression) extends Logging {
*/
def rlike(literal: String): Column = withExpr { RLike(expr, lit(literal).expr) }
+ /**
+ * SQL ILIKE expression (case insensitive LIKE).
+ *
+ * @group expr_ops
+ * @since 3.3.0
+ */
+ def ilike(literal: String, escapeChar: Char = '\\'): Column = withExpr {
Review comment:
yeah, let's don't add it for now. these DSL APIs don't usually have all matched APIs but just commonly used ones (that make sense to Scala, Python, etc users instead of SQL users)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921544033
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47900/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34027:
URL: https://github.com/apache/spark/pull/34027#discussion_r710759953
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -846,6 +846,17 @@ class Column(val expr: Expression) extends Logging {
*/
def rlike(literal: String): Column = withExpr { RLike(expr, lit(literal).expr) }
+ /**
+ * SQL ILIKE expression (case insensitive LIKE).
+ *
+ * @group expr_ops
+ * @since 3.3.0
+ */
+ def ilike(literal: String): Column = withExpr {
+ ILike(expr, lit(literal).expr, '\\',
+ Like(Lower(expr), Lower(lit(literal).expr), '\\'))
+ }
Review comment:
```suggestion
def ilike(literal: String): Column = withExpr { ILike(expr, lit(literal).expr) }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921414115
**[Test build #143383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143383/testReport)** for PR 34027 at commit [`f7019ca`](https://github.com/apache/spark/commit/f7019caaa2d52e051949c2b937e363b5e981717b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921504630
**[Test build #143393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143393/testReport)** for PR 34027 at commit [`a8ad299`](https://github.com/apache/spark/commit/a8ad299d64b51937441c56a8ea891cbfdf60a611).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921826601
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143408/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921417373
Jenkins, ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921431823
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47890/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921585810
**[Test build #143384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143384/testReport)** for PR 34027 at commit [`f7019ca`](https://github.com/apache/spark/commit/f7019caaa2d52e051949c2b937e363b5e981717b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921685847
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921593812
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143383/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921418365
**[Test build #143384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143384/testReport)** for PR 34027 at commit [`f7019ca`](https://github.com/apache/spark/commit/f7019caaa2d52e051949c2b937e363b5e981717b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on a change in pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on a change in pull request #34027:
URL: https://github.com/apache/spark/pull/34027#discussion_r710891751
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -846,6 +846,17 @@ class Column(val expr: Expression) extends Logging {
*/
def rlike(literal: String): Column = withExpr { RLike(expr, lit(literal).expr) }
+ /**
+ * SQL ILIKE expression (case insensitive LIKE).
+ *
+ * @group expr_ops
+ * @since 3.3.0
+ */
+ def ilike(literal: String): Column = withExpr {
+ ILike(expr, lit(literal).expr, '\\',
+ Like(Lower(expr), Lower(lit(literal).expr), '\\'))
+ }
Review comment:
Thank you, I changed here to use overloaded constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921593812
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143383/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921676165
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143393/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921824991
**[Test build #143408 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143408/testReport)** for PR 34027 at commit [`b26ae27`](https://github.com/apache/spark/commit/b26ae2772400de4286191d93daddb547c41266e2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34027: [SPARK-36778] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34027:
URL: https://github.com/apache/spark/pull/34027#discussion_r710676234
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -846,6 +846,17 @@ class Column(val expr: Expression) extends Logging {
*/
def rlike(literal: String): Column = withExpr { RLike(expr, lit(literal).expr) }
+ /**
+ * SQL ILIKE expression (case insensitive LIKE).
+ *
+ * @group expr_ops
+ * @since 3.3.0
+ */
+ def ilike(literal: String, escapeChar: Char = '\\'): Column = withExpr {
Review comment:
Let's forget about `escapeChar` for now. I don't think it's used pretty often, and it's not exposed in `like` above too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921674421
**[Test build #143393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143393/testReport)** for PR 34027 at commit [`a8ad299`](https://github.com/apache/spark/commit/a8ad299d64b51937441c56a8ea891cbfdf60a611).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921727134
+1, LGTM. Merging to master.
Thank you, @yoda-mon and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921685906
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921433541
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921413887
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921504630
**[Test build #143393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143393/testReport)** for PR 34027 at commit [`a8ad299`](https://github.com/apache/spark/commit/a8ad299d64b51937441c56a8ea891cbfdf60a611).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921592010
**[Test build #143383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143383/testReport)** for PR 34027 at commit [`f7019ca`](https://github.com/apache/spark/commit/f7019caaa2d52e051949c2b937e363b5e981717b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921418365
**[Test build #143384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143384/testReport)** for PR 34027 at commit [`f7019ca`](https://github.com/apache/spark/commit/f7019caaa2d52e051949c2b937e363b5e981717b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34027:
URL: https://github.com/apache/spark/pull/34027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921826601
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143408/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921643918
**[Test build #143408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143408/testReport)** for PR 34027 at commit [`b26ae27`](https://github.com/apache/spark/commit/b26ae2772400de4286191d93daddb547c41266e2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921587050
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143384/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34027: [SPARK-36778] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921405308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921467286
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47891/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921415079
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921676165
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143393/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921447774
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47891/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921587050
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143384/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on a change in pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on a change in pull request #34027:
URL: https://github.com/apache/spark/pull/34027#discussion_r710704819
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -846,6 +846,17 @@ class Column(val expr: Expression) extends Logging {
*/
def rlike(literal: String): Column = withExpr { RLike(expr, lit(literal).expr) }
+ /**
+ * SQL ILIKE expression (case insensitive LIKE).
+ *
+ * @group expr_ops
+ * @since 3.3.0
+ */
+ def ilike(literal: String, escapeChar: Char = '\\'): Column = withExpr {
Review comment:
I think so too, but I'd like to confirm that from SQL, it seems we can use `escapeChar`.
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala#L231
Is that OK to close `escapeChar` on dataframe ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921441538
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47891/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921526655
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47900/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921467286
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47891/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921531096
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47900/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921434975
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47890/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921434998
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47890/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921679233
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47916/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921413887
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34027:
URL: https://github.com/apache/spark/pull/34027#issuecomment-921415079
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org