[GitHub] [incubator-nuttx] mlyszczek commented on a diff in pull request #6723: sched: Fill the gap in the structures.

[GitBox <gi...@apache.org>]

mlyszczek commented on code in PR #6723:
URL: https://github.com/apache/incubator-nuttx/pull/6723#discussion_r932733242


##########
sched/mqueue/mqueue.h:
##########
@@ -65,11 +65,7 @@ struct mqueue_msg_s
   struct list_node node;   /* Link node to message */
   uint8_t type;            /* (Used to manage allocations) */
   uint8_t priority;        /* Priority of message */
-#if MQ_MAX_BYTES < 256
-  uint8_t msglen;          /* Message data length */

Review Comment:
   I don't think this is going to be true for 8bit processors? Not 100% sure but I'm pretty sure alignment on 8bit mcu will be 1byte.
   
   Since nuttx claims it's working fine even on 8bit mcu, it may not be best thing to do. Same thing with adding ```unsigned char``` as padding. What about 8bit mcus? They don't need padding there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org